feat: Add WebSocket logic to network access Snap#3458
Merged
FrederikBolding merged 4 commits intomainfrom Jun 17, 2025
Merged
Conversation
FrederikBolding
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3458 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 404 404
Lines 11317 11334 +17
Branches 1764 1766 +2
=======================================
+ Hits 11115 11132 +17
Misses 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FrederikBolding
force-pushed
the
fb/ws-example
branch
from
b8700f7 to
722c37e
Compare
Mrtenz
reviewed
Jun 17, 2025
Member
Mrtenz
left a comment
Mrtenz
left a comment
There was a problem hiding this comment.
Please update the README of the example as well.
packages/test-snaps/src/features/snaps/network-access/NetworkAccess.tsx
Outdated
Show resolved
Hide resolved
Mrtenz
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands the network access Snap to support opening a WebSocket connection and subscribing to block updates from a local Ethereum node. Additionally fixes some mistakes made in the original WebSocket PR.
Closes #3456