Skip to content

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Jun 18, 2025

This adds the missing name and state properties to WebSocketService, enabling initialisation through the controller init pattern in the clients.

@codecov
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (728e3f7) to head (639d11c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3464   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files         404      404           
  Lines       11334    11336    +2     
  Branches     1766     1766           
=======================================
+ Hits        11132    11134    +2     
  Misses        202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mrtenz Mrtenz marked this pull request as ready for review June 18, 2025 09:21
@Mrtenz Mrtenz requested a review from a team as a code owner June 18, 2025 09:21
@Mrtenz Mrtenz added this pull request to the merge queue Jun 18, 2025
Merged via the queue into main with commit 5450fd9 Jun 18, 2025
119 checks passed
@Mrtenz Mrtenz deleted the mrtenz/websocket-service-boilerplate branch June 18, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants