-
Notifications
You must be signed in to change notification settings - Fork 639
feat!: Add onAssetsMarketData handler
#3496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3496 +/- ##
==========================================
+ Coverage 98.21% 98.23% +0.01%
==========================================
Files 404 406 +2
Lines 11336 11441 +105
Branches 1766 1783 +17
==========================================
+ Hits 11134 11239 +105
Misses 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
onAssetsMarketData handleronAssetsMarketData handler
Co-authored-by: Frederik Bolding <[email protected]>
Co-authored-by: Frederik Bolding <[email protected]>
FrederikBolding
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but lets hold off until we are ready for the breaking change elsewhere
BREAKING
This PR adds a new handler called
onAssetsMarketDataand moves themarketDatafield ofonAssetsConversionto it.Fixes: #3474