Skip to content

Conversation

@GuillaumeRx
Copy link
Contributor

BREAKING

This PR adds a new handler called onAssetsMarketData and moves the marketData field of onAssetsConversion to it.

Fixes: #3474

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner June 23, 2025 13:51
@codecov
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.23%. Comparing base (38b152a) to head (950671f).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3496      +/-   ##
==========================================
+ Coverage   98.21%   98.23%   +0.01%     
==========================================
  Files         404      406       +2     
  Lines       11336    11441     +105     
  Branches     1766     1783      +17     
==========================================
+ Hits        11134    11239     +105     
  Misses        202      202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding changed the title feat: Add onAssetsMarketData handler feat!: Add onAssetsMarketData handler Jun 23, 2025
Co-authored-by: Frederik Bolding <[email protected]>
Co-authored-by: Frederik Bolding <[email protected]>
Copy link
Member

@FrederikBolding FrederikBolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but lets hold off until we are ready for the breaking change elsewhere

@FrederikBolding FrederikBolding added this pull request to the merge queue Jun 27, 2025
Merged via the queue into main with commit 1d114eb Jun 27, 2025
119 checks passed
@FrederikBolding FrederikBolding deleted the gr/on-assets-market-data branch June 27, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new onAssetsMarketData handler and move market data out of onAssetsConversion

3 participants