Skip to content

Conversation

@FrederikBolding
Copy link
Member

Show a different error message for cancelled requests when the Snap is stopped. Right now, we show the generic "failed to respond in time" message, which is very confusing.

@codecov
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (7a1340b) to head (fc55b9d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3518   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         408      408           
  Lines       11517    11520    +3     
  Branches     1792     1795    +3     
=======================================
+ Hits        11315    11318    +3     
  Misses        202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding marked this pull request as ready for review July 1, 2025 10:12
@FrederikBolding FrederikBolding requested a review from a team as a code owner July 1, 2025 10:12
GuillaumeRx
GuillaumeRx previously approved these changes Jul 1, 2025
cursor[bot]

This comment was marked as outdated.

@FrederikBolding FrederikBolding added this pull request to the merge queue Jul 1, 2025
Merged via the queue into main with commit 2786b0e Jul 1, 2025
120 checks passed
@FrederikBolding FrederikBolding deleted the fb/improve-crash-error-message branch July 1, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants