feat: Add snap_startTrace and snap_endTrace methods for performance tracing
#3519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3519 +/- ##
=======================================
Coverage 98.24% 98.25%
=======================================
Files 408 410 +2
Lines 11537 11583 +46
Branches 1797 1801 +4
=======================================
+ Hits 11335 11381 +46
Misses 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mrtenz
changed the title
snap_startTrace and snap_endTrace methods for performance tracingsnap_startTrace and snap_endTrace methods for performance tracing
Mrtenz
force-pushed
the
mrtenz/performance-tracing
branch
from
7b2785e to
81cf0b1
Compare
Mrtenz
force-pushed
the
mrtenz/performance-tracing
branch
from
81cf0b1 to
4f95cb5
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| }); | ||
| } | ||
|
|
||
| case 'startTrace': |
Member
There was a problem hiding this comment.
Not for this PR, but we should add the metrics method to this Snap too so we can test it all
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
FrederikBolding
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two methods,
snap_startTraceandsnap_endTrace, intended to hook into the performance tracing functionality of Sentry. They are essentially wrappers of thetraceandendTracefunctions in the clients.