Skip to content

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Jul 2, 2025

This adds a new feature flag forcePreinstalledSnaps, which makes the SnapController treat any local Snaps as preinstalled Snaps.

It's intended to only be enabled in local Flask builds, and should not be enabled in any production builds. It can be used to simplify the development of preinstalled Snaps by using a local Snap instead.

Related extension PR: MetaMask/metamask-extension#34022.

Closes #3517.

@codecov
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.25%. Comparing base (46c9eb9) to head (136c886).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3523      +/-   ##
==========================================
+ Coverage   98.24%   98.25%   +0.01%     
==========================================
  Files         408      410       +2     
  Lines       11520    11588      +68     
  Branches     1795     1804       +9     
==========================================
+ Hits        11318    11386      +68     
  Misses        202      202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mrtenz Mrtenz marked this pull request as ready for review July 3, 2025 09:58
@Mrtenz Mrtenz requested a review from a team as a code owner July 3, 2025 09:58
@Mrtenz Mrtenz added this pull request to the merge queue Jul 3, 2025
Merged via the queue into main with commit 20ed5ef Jul 3, 2025
120 checks passed
@Mrtenz Mrtenz deleted the mrtenz/preinstalled-snaps-feature-flag branch July 3, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add feature flag for allowing methods normally only available to preinstalled Snaps

3 participants