Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3532 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 411 411
Lines 11618 11619 +1
Branches 1810 1810
=======================================
+ Hits 11416 11417 +1
Misses 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Box in RowRow
There was a problem hiding this comment.
Needs a JSDoc update for children
GuillaumeRx
left a comment
There was a problem hiding this comment.
We also need to add Value to BoxChildStruct
There was a problem hiding this comment.
Bug: TypeScript and Runtime Validation Mismatch
The RowChildren TypeScript type and its JSDoc were updated to allow 'any component', but runtime validation in validation.ts still restricts Row children to ValueStruct and BoxChildStruct. This discrepancy causes TypeScript-valid components to fail runtime validation and results in misleading documentation.
packages/snaps-sdk/src/jsx/components/Row.ts#L6-L13
snaps/packages/snaps-sdk/src/jsx/components/Row.ts
Lines 6 to 13 in b3c0b47
Was this report helpful? Give feedback by reacting with 👍 or 👎
Allow
BoxChildStructas child ofRow. This enables a bunch of additional use-cases forRowby allowing any component as its child.