fix: Use custom state manager for cronjob controller

[Mrtenz]

This updates the cronjob controller to add a custom stateManager property for persisting state. This is a temporary workaround for the controller persisting state too often, causing the entire client state to be written.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.26%. Comparing base (ca23eda) to head (0672fed).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3539   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files         411      411           
  Lines       11619    11624    +5     
  Branches     1810     1810           
=======================================
+ Hits        11417    11422    +5     
  Misses        202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[GuillaumeRx]

I guess this means we will always overwrite an obsolete state after the first init but that looks fine for now.

[Mrtenz]

getInitialState may be undefined

[GuillaumeRx]

Yeah and we still need to recover the state the first time

[cursor]

Bug: State Initialization Fails When Undefined is Spread

The CronjobController constructor's state initialization attempts to spread stateManager.getInitialState(), which can return undefined. Spreading undefined in an object literal causes a TypeError at runtime. Additionally, the state merge order (...state, ...stateManager.getInitialState()) means that properties from the state constructor parameter are silently overridden by those from stateManager.getInitialState() if keys conflict.

packages/snaps-controllers/src/cronjob/CronjobController.ts#L183-L188

snaps/packages/snaps-controllers/src/cronjob/CronjobController.ts

Lines 183 to 188 in 0672fed

	name: controllerName,
	state: {
	events: {},
	...state,
	...stateManager.getInitialState(),
	},

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎