feat: Add onActive and onInactive lifecycle hooks
#3542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
commented
Jul 21, 2025
| * | ||
| * @param active - A boolean indicating whether the client is active or not. | ||
| */ | ||
| setActive(active: boolean) { |
Member
Author
There was a problem hiding this comment.
This seems to be the easiest solution given that at least the extension doesn't seem to emit any events when the active status changes. I'm open to other suggestions though.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3542 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 411 411
Lines 11624 11637 +13
Branches 1810 1814 +4
=======================================
+ Hits 11422 11435 +13
Misses 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
GuillaumeRx
requested changes
Jul 22, 2025
Co-authored-by: Guillaume Roux <[email protected]>
Co-authored-by: Guillaume Roux <[email protected]>
GuillaumeRx
requested changes
Jul 22, 2025
GuillaumeRx
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the
onActiveandonInactivelifecycle hooks. It's accomplished by exposing a newsetActiveaction in the Snap controller, which should be called by the clients when the active status changes.Related to #3541.