feat: Allow eval in watch mode #3553
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3553 +/- ##
==========================================
- Coverage 98.28% 98.27% -0.01%
==========================================
Files 417 417
Lines 11765 11758 -7
Branches 1827 1827
==========================================
- Hits 11563 11555 -8
- Misses 202 203 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| writeFileFn = fs.writeFile, | ||
| exports, | ||
| handlerEndowments, | ||
| watchMode = false, |
There was a problem hiding this comment.
Would it be a lot more complicated to implement minimumSeverity or something instead of coupling this to watchMode?
There was a problem hiding this comment.
Depends on if you think minimumSeverity === 'warning' is enough or if you want me to implement a proper algorithm ranking severities
There was a problem hiding this comment.
Hmm, I was hoping it would be easy if our severities were already tied to numbers, but I guess they may not be. If they were it would be as simple as >= minimumSeverity
There was a problem hiding this comment.
They are not, it's just 'warning' | 'error' at the moment.
There was a problem hiding this comment.
Refactoring that feels out of scope
Evaluating the Snap bundle in watch mode was previously disabled because it could result in, for example, permissions being removed from the manifest immediately, because of some validator rules. In this PR, I've updated the logic so only manifest errors are fixed immediately in watch mode. Warnings are not fixed in watch mode, but are still fixed in build or when running
mm-snap manifest --fix.Closes #3536.