Skip to content

Conversation

@FrederikBolding
Copy link
Member

When a Snap fails to start we call terminateSnap (https://github.com/MetaMask/snaps/blob/main/packages/snaps-controllers/src/snaps/SnapController.ts#L3162), but this may fail if the Snap has not fully started.

To prevent logging unnecessary errors to Sentry, this PR allows calls to terminateSnap even if the Snap is not currently executing, if no job is found the we just return early.

@FrederikBolding FrederikBolding requested a review from a team as a code owner August 4, 2025 09:50
@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.27%. Comparing base (53180b4) to head (449b9da).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3559   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files         417      417           
  Lines       11758    11758           
  Branches     1827     1827           
=======================================
  Hits        11555    11555           
  Misses        203      203           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into main with commit 128b47d Aug 4, 2025
120 checks passed
@FrederikBolding FrederikBolding deleted the fb/stop-throwing-if-snap-does-not-exist branch August 4, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants