fix: Merge manifest validation reports to include latest validation errors and warnings

[Mrtenz]

This updates the manifest validation to merge new reports after the initial validation. We run the validation logic in a loop to address any newly found issues, but previously, newly found errors or warnings were never actually surfaced: Only the reports found in the initial validation were used.

After this change, each report has an ID based on the name of the report, and for validators with multiple potential errors (e.g., unused exports/endowments), a different ID is used as well. This ensures we can merge reports without duplicating them (causing two shasum warnings for example).

Closes #3505.

[Mrtenz]

This just disables the file system cache. We mock network requests anyway, and doing this makes testing a bit easier.

[FrederikBolding]

What does this make easier?

[Mrtenz]

I couldn't figure out how to test the new invalid platform version warning showing up without changing this. It would always cache the correct version.

[FrederikBolding]

Not sure I understand how this changes that, the mock returns the platform version from getPlatformVersion anyways 🤔

[Mrtenz]

The test replaces the fetch mock.

fetchMock.mockResponseOnce(MOCK_GITHUB_RESPONSE).mockResponseOnce(
  JSON.stringify({
    dependencies: {
      '@metamask/snaps-sdk': '1.0.0',
    },
  }),
);

[FrederikBolding]

Maybe try if clearing it out in resetFileSystem fixes it? Otherwise fine to merge as-is

[Mrtenz]

The cache seems to be written to the real file system, or at least I can't find where it is in the virtual file system 🤔

[FrederikBolding]

I would expect something like this:
await fs.rm('./node_modules/.cache/snaps', { recursive: true, force: true });

Does that not work?

[Mrtenz]

It doesn't, I'm not seeing the node_modules/.cache folder anywhere in the VFS

[FrederikBolding]

Strange 🤔

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.28%. Comparing base (29b393e) to head (bdad04f).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3567   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         417      417           
  Lines       11764    11769    +5     
  Branches     1829     1830    +1     
=======================================
+ Hits        11562    11567    +5     
  Misses        202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.