-
Notifications
You must be signed in to change notification settings - Fork 639
release: 124.0.0
#3603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 124.0.0
#3603
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3603 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 417 417
Lines 11772 11772
Branches 1832 1832
=======================================
Hits 11570 11570
Misses 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cryptodev-2s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a small note on the changelog, but nothing blocking the release.
| ### Fixed | ||
|
|
||
| - Throw clearer error when the NPM registry returns 404 ([#3602](https://github.com/MetaMask/snaps/pull/3602)) | ||
| - Only log error that originally caused the crash ([#3569](https://github.com/MetaMask/snaps/pull/3569)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: The changelog could be clearer, it’s hard to understand what’s being fixed without checking the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cryptodev-2s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This is the release candidate for version
124.0.0.