Skip to content

Conversation

@FrederikBolding
Copy link
Member

Our Webpack plugin uses Prettier at runtime but does not specify it as a dependency. This breaks in repositories that do not have the expected version of Prettier already in the dependency tree.

@FrederikBolding FrederikBolding requested a review from a team as a code owner August 27, 2025 09:30
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FrederikBolding FrederikBolding changed the title fix: Add prettier as a regular dependency for snaps-webpack-plugin fix: Add prettier as a runtime dependency for snaps-webpack-plugin Aug 27, 2025
@codecov
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.28%. Comparing base (1382bf5) to head (08bd9cc).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3615   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         417      417           
  Lines       11772    11772           
  Branches     1832     1832           
=======================================
  Hits        11570    11570           
  Misses        202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding added this pull request to the merge queue Aug 27, 2025
Merged via the queue into main with commit 0032341 Aug 27, 2025
121 checks passed
@FrederikBolding FrederikBolding deleted the fb/fix-missing-prettier-dep branch August 27, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants