-
Notifications
You must be signed in to change notification settings - Fork 639
feat!: Allow updating preinstalled Snaps via the registry #3616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a072312 to
344d7ad
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3616 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 417 417
Lines 11768 11793 +25
Branches 1830 1841 +11
=======================================
+ Hits 11566 11591 +25
Misses 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d7767b0 to
6aa66d9
Compare
Mrtenz
requested changes
Sep 2, 2025
Mrtenz
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow updating preinstalled Snaps by updating their entry in the registry. This is accomplished by searching the registry for updates whenever
updateRegistryis called and triggering#updateSnap. As part of this PR the previously namedupdateBlockedSnapshas been renamed toupdateRegistryand a flag to allow automatic updates has been added to#updateSnap.When an update is automatic, the permissions requested by the Snap are applied automatically similarly to how a preinstalled Snap is initialized. Preinstalled Snaps can still be installed and updated via the constructor. In case of any errors applying the update, the Snap is rolled back to its previous state.
This behavior is put behind a feature flag that we can decide to enable at a later date.
Closes #3593