fix: Properly roll back initialConnections
#3618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3618 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 417 417
Lines 11772 11777 +5
Branches 1832 1834 +2
=======================================
+ Hits 11570 11575 +5
Misses 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FrederikBolding
force-pushed
the
fb/roll-back-initial-connections
branch
from
6f0c4c0 to
ce4e5ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current rollback approach did not account for
initialConnections, which are handled separately from other permissions because they are somewhat complicated to apply. If a Snap failed to update, we would not correctly roll back the changes to theinitialConnections. This PR fixes that issue.Fixes #3619