Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Sep 29, 2025

Sync the icon list with the current list from the extension. This includes breaking changes as some icons were removed.

Closes #3652


Note

Syncs the IconName enum to the extension (many additions, some removals/renames causing breaks) and updates an example snap manifest shasum.

  • SDK:
    • Icon list sync: Updates IconName in packages/snaps-sdk/src/jsx/components/Icon.ts to match the extension.
      • Adds numerous icons (e.g., Accessibility, Ai, ArrowCircleDown, CloudUpload, Exchange, HomeFilled, Send, StarFilled, Verified, WalletFilled, etc.).
      • Removes/renames legacy entries (e.g., Send1/Send2, Import, NotificationCircle, LockCircle, SecurityCard, CardToken, BankToken, Custody, UserCircleLink, PlusMinus, Timer, Tilde, etc.).
      • Includes breaking changes due to removed/renamed enum values.
  • Examples:
    • Update packages/examples/packages/send-flow/snap.manifest.json source.shasum.

Written by Cursor Bugbot for commit f627d38. This will update automatically on new commits. Configure here.

@FrederikBolding FrederikBolding requested a review from a team as a code owner September 29, 2025 12:48
@FrederikBolding
Copy link
Member Author

@metamaskbot update-pr

@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.30%. Comparing base (395c34d) to head (f627d38).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3656      +/-   ##
==========================================
+ Coverage   98.28%   98.30%   +0.01%     
==========================================
  Files         417      417              
  Lines       11811    11927     +116     
  Branches     1844     1844              
==========================================
+ Hits        11609    11725     +116     
  Misses        202      202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding added this pull request to the merge queue Sep 29, 2025
Merged via the queue into main with commit 9a39a72 Sep 29, 2025
122 checks passed
@FrederikBolding FrederikBolding deleted the fb/sync-icons branch September 29, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

the Send1 and Send2 icons are broken

4 participants