-
Notifications
You must be signed in to change notification settings - Fork 637
perf: Reduce JSON validation during state updates #3660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
previously approved these changes
Oct 1, 2025
Member
Author
|
@metamaskbot update-pr |
Mrtenz
previously approved these changes
Oct 1, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3660 +/- ##
==========================================
+ Coverage 98.27% 98.29% +0.01%
==========================================
Files 417 417
Lines 11902 11907 +5
Branches 1843 1848 +5
==========================================
+ Hits 11697 11704 +7
+ Misses 205 203 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
232c9a5 to
c30529b
Compare
Mrtenz
approved these changes
Oct 1, 2025
b843d1d to
ead59ca
Compare
ead59ca to
168610a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two changes to improve performance in
snap_setStateandsnap_manageState:snap_setStateNote
Optimizes
snap_setState/snap_manageStateby usinggetSnapandgetJsonSizeUnsafeto enforce size limits only for non-preinstalled Snaps, removes redundant JSON validation, updates hooks/simulation, adds TextEncoder allowances, and adjusts tests and coverage.snap_setState(packages/snaps-rpc-methods/src/permitted/setState.ts): AddgetSnaphook; replacegetJsonSizewithgetJsonSizeUnsafe(..., true); enforce storage size only for non-preinstalledSnaps.snap_manageState(packages/snaps-rpc-methods/src/restricted/manageState.ts): AddgetSnaphook; move size check to method implementation usinggetJsonSizeUnsafe(..., true)(skip forpreinstalled); validation now usesisValidJsonand no longer checks size.getSnapand wire implementation (packages/snaps-simulation/src/simulation.ts).getJsonSizeUnsafeto optionally measure byte length viaTextEncoderand add tests (packages/snaps-utils/src/json.ts,json.test.ts).TextEncoderin LavaMoat policies for@metamask/snaps-utils(iframe/node-process/node-thread/webview policies).getSnapand cover large state error paths; remove size check from param validation (manageState.test.ts,setState.test.ts).packages/snaps-rpc-methods/jest.config.js).Written by Cursor Bugbot for commit 168610a. This will update automatically on new commits. Configure here.