-
Notifications
You must be signed in to change notification settings - Fork 637
chore: Bump @metamask/phishing-controller from 13.1.0 to 14.1.2 #3678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump @metamask/phishing-controller from 13.1.0 to 14.1.2 #3678
Conversation
Bumps [@metamask/phishing-controller](https://github.com/MetaMask/core) from 13.1.0 to 14.1.2. - [Release notes](https://github.com/MetaMask/core/releases) - [Changelog](https://github.com/MetaMask/core/blob/main/docs/reviewing-release-prs.md) - [Commits](https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected]) --- updated-dependencies: - dependency-name: "@metamask/phishing-controller" dependency-version: 14.1.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Caution MetaMask internal reviewing guidelines:
|
| punycode: "npm:^2.1.1" | ||
| checksum: 10/c62f71291736dfd635cc69b2d422687d8d610591a5e1cd9a6b4806cdc19221a72fe7699c0cabe0a2a108b49c3cc4dcb88a5b283fba374fe13e54d5813fb77902 | ||
| peerDependencies: | ||
| "@metamask/transaction-controller": ^60.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing Dependency Causes Runtime Issues
The update to @metamask/[email protected] introduces a peer dependency on @metamask/transaction-controller: ^60.4.0. The consuming packages, @metamask/snaps-controllers and @metamask/snaps-simulation, do not declare this dependency, which may lead to runtime errors, warnings, or missing functionality.
Additional Locations (2)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3678 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 417 417
Lines 11924 11924
Branches 1852 1852
=======================================
Hits 11721 11721
Misses 203 203 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Superseded by #3700. |
Bumps @metamask/phishing-controller from 13.1.0 to 14.1.2.
Commits
1198ad7Release/613.0.0 (#6816)6ee073cfix: update hotlist endpoint to v2 and remove blocklistPaths query parameter ...bd83f03chore: remove collection API calls from NFT detection process (#6762)96f4678fix: prune wallet metadata on account removal (#6813)1cbdf43Release/612.0.0 (#6814)181b62bfix(account-tree-controller): ensure wallet legacy fields are always present ...09f3fd5Release/611.0.0 (#6810)903c1a1Release/610.0.0 (#6809)cc42c42Release/609.0.0 (#6807)34f185ffeat: add blocklist paths flag for hotlist (#6808)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Note
Bumps @metamask/phishing-controller to 14.1.2, updates LavaMoat policies, and refreshes example snap manifest shasums.
@metamask/phishing-controllerfrom^13.1.0to^14.1.2inpackages/snaps-controllersandpackages/snaps-simulation.yarn.lockto reflect new versions (e.g.,@metamask/[email protected],@noble/[email protected]) and add peer dep@metamask/transaction-controller@^60.4.0forphishing-controller.TextDecoderglobal to@metamask/utils>@noble/hashesinwebpack/iframe,node-process,node-thread, andwebviewpolicies.source.shasumin multiple example snap manifests (e.g.,packages/examples/packages/*/snap.manifest.json) to new bundle checksums.Written by Cursor Bugbot for commit ad7fefa. This will update automatically on new commits. Configure here.