-
Notifications
You must be signed in to change notification settings - Fork 639
release: 128.0.0
#3690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 128.0.0
#3690
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3690 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 417 417
Lines 11925 11925
Branches 1851 1851
=======================================
Hits 11722 11722
Misses 203 203 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
README.md
Outdated
| snaps_webpack_plugin --> snaps_rpc_methods; | ||
| snaps_webpack_plugin --> snaps_sdk; | ||
| snaps_webpack_plugin --> snaps_utils; | ||
| test_snaps --> examples/packages/background_events; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this part of the diagram?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just the result of the pre commit hook, I didn't add anything manually. 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, I'm just asking if we want to omit this part of the diagram
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem like an important part and takes up a bunch of space 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted the changes in this PR, seems out of scope anyway.
Note
Bumps packages for a release with JSON-RPC mocking support in testing/simulation and fixes around Snap installation and manageAccounts handling.
@metamask/[email protected]and@metamask/[email protected]@metamask/[email protected]manageAccountsrequests.@metamask/[email protected]128.0.0.Written by Cursor Bugbot for commit 2f29c72. This will update automatically on new commits. Configure here.