Skip to content

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Oct 20, 2025

Note

Bumps packages for a release with JSON-RPC mocking support in testing/simulation and fixes around Snap installation and manageAccounts handling.

Written by Cursor Bugbot for commit 2f29c72. This will update automatically on new commits. Configure here.

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.29%. Comparing base (fff1ef6) to head (2f29c72).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3690   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         417      417           
  Lines       11925    11925           
  Branches     1851     1851           
=======================================
  Hits        11722    11722           
  Misses        203      203           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mrtenz Mrtenz marked this pull request as ready for review October 20, 2025 10:00
@Mrtenz Mrtenz requested a review from a team as a code owner October 20, 2025 10:00
README.md Outdated
snaps_webpack_plugin --> snaps_rpc_methods;
snaps_webpack_plugin --> snaps_sdk;
snaps_webpack_plugin --> snaps_utils;
test_snaps --> examples/packages/background_events;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this part of the diagram?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just the result of the pre commit hook, I didn't add anything manually. 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, I'm just asking if we want to omit this part of the diagram

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem like an important part and takes up a bunch of space 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion on it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the changes in this PR, seems out of scope anyway.

@Mrtenz Mrtenz added this pull request to the merge queue Oct 20, 2025
Merged via the queue into main with commit 3fda705 Oct 20, 2025
121 checks passed
@Mrtenz Mrtenz deleted the release/128.0.0 branch October 20, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants