Skip to content

Conversation

@mikesposito
Copy link
Member

@mikesposito mikesposito commented Oct 23, 2025

Note

Switches to a Yarn-patched @metamask/[email protected] across snaps packages and updates invokeSnap to use a messenger param with adjusted tests and typings.

  • Dependencies:
    • Replace @metamask/permission-controller@^11.0.6 with Yarn patch reference in packages/snaps-controllers, packages/snaps-rpc-methods, packages/snaps-simulation, and packages/snaps-utils.
    • Update yarn.lock to include patched resolution.
  • RPC Methods:
    • packages/snaps-rpc-methods/src/restricted/invokeSnap.ts:
      • Rename messagingSystem to messenger in handleSnapInstall and update calls to messenger.call for SnapController:getPermitted and SnapController:install.
    • Tests (invokeSnap.test.ts):
      • Adjust Messenger generics and switch to messenger param in handleSnapInstall calls.
  • Simulation Controllers:
    • packages/snaps-simulation/src/controllers.ts: remove ts-expect-error and construct controllers with typed messenger.

Written by Cursor Bugbot for commit 5c66d70. This will update automatically on new commits. Configure here.

@mikesposito mikesposito changed the base branch from main to fb/base-controller-migration October 23, 2025 23:42
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.28%. Comparing base (68c50b9) to head (5c66d70).
⚠️ Report is 1 commits behind head on fb/base-controller-migration.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           fb/base-controller-migration    #3697   +/-   ##
=============================================================
  Coverage                         98.28%   98.28%           
=============================================================
  Files                               418      418           
  Lines                             12152    12152           
  Branches                           1876     1876           
=============================================================
  Hits                              11943    11943           
  Misses                              209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mikesposito mikesposito marked this pull request as ready for review October 24, 2025 12:52
@mikesposito mikesposito requested a review from a team as a code owner October 24, 2025 12:52
@mikesposito mikesposito merged commit 6992e4e into fb/base-controller-migration Oct 24, 2025
120 checks passed
@mikesposito mikesposito deleted the me/use-permission-controller-preview branch October 24, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants