-
Notifications
You must be signed in to change notification settings - Fork 637
feat: Add DateTimePicker component
#3698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c60d86e to
fcfa7f6
Compare
8fd673b to
1df57ef
Compare
1df57ef to
2f0b675
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3698 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 418 420 +2
Lines 12186 12211 +25
Branches 1887 1889 +2
=======================================
+ Hits 11977 12002 +25
Misses 209 209 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Frederik Bolding <[email protected]>
Co-authored-by: Frederik Bolding <[email protected]>
packages/examples/packages/interactive-ui/src/components/InteractiveForm.tsx
Show resolved
Hide resolved
FrederikBolding
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
DateTimePickercomponentNote
Introduces a new
DateTimePickerJSX component (with ISO 8601 validation), adds simulation/Jest support viapickDateTime, integrates in controllers/state, and showcases it in the interactive UI example.DateTimePickercomponent (jsx/components/form/DateTimePicker.ts) with tests and validation (DateTimePickerStruct).ISO8601DateStructininternals/time(usingluxon) and export via SDK; update validation to use it.Fieldand form typings/exports to includeDateTimePicker.luxondependency and types.DateTimePickeras stateful in interface utils; support default/state construction in forms and root.pickDateTimeaction across simulation API and handler interfaces; wire events/state updates; extensive tests.pickDateTimein Jest helpers and mock interface responses.snap_createInterfacevalidation/error messages to allowDateTimePicker.@metamask/snaps-sdk>luxonandIntl.snaps-utils/timenow re-exportsISO8601DateStructand retains duration utilities.luxonand types.Written by Cursor Bugbot for commit 85563a0. This will update automatically on new commits. Configure here.