Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 27, 2025

Bumps @metamask/phishing-controller from 13.1.0 to 14.1.3.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note

Upgrades @metamask/phishing-controller to v15 across packages, updates lockfile, adds TextDecoder to LavaMoat policies, and refreshes example snap bundle shasums.

  • Dependencies:
    • Bump @metamask/phishing-controller to ^15.0.0 in packages/snaps-controllers, packages/snaps-simulation, and as a devDependency in packages/snaps-jest; update yarn.lock accordingly (includes related transitive updates like @noble/hashes).
  • Security/Policy:
    • Add TextDecoder global for @metamask/utils>@noble/hashes in LavaMoat policies for iframe, node-process, node-thread, and webview.
  • Examples:
    • Update source.shasum in multiple example snap manifests (e.g., bip32, bip44, cronjobs, dialogs, ethereum-provider, ethers-js, get-entropy, images, interactive-ui, invoke-snap/*, send-flow, signature-insights, transaction-insights).

Written by Cursor Bugbot for commit ca2abc4. This will update automatically on new commits. Configure here.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Oct 27, 2025
@dependabot dependabot bot requested a review from a team as a code owner October 27, 2025 06:17
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Oct 27, 2025
cursor[bot]

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.28%. Comparing base (7baa5d9) to head (ca2abc4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3700   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         418      418           
  Lines       12152    12152           
  Branches     1876     1876           
=======================================
  Hits        11943    11943           
  Misses        209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/main/metamask/phishing-controller-14.1.3 branch from 0045695 to bc9a9dc Compare October 27, 2025 22:31
cursor[bot]

This comment was marked as outdated.

Bumps [@metamask/phishing-controller](https://github.com/MetaMask/core) from 13.1.0 to 14.1.3.
- [Release notes](https://github.com/MetaMask/core/releases)
- [Changelog](https://github.com/MetaMask/core/blob/main/docs/reviewing-release-prs.md)
- [Commits](https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected])

---
updated-dependencies:
- dependency-name: "@metamask/phishing-controller"
  dependency-version: 14.1.3
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/main/metamask/phishing-controller-14.1.3 branch from 0edbb42 to 9c1c0dd Compare October 27, 2025 23:51
"@metamask/object-multiplex": "^2.1.0",
"@metamask/permission-controller": "^12.0.0",
"@metamask/phishing-controller": "^13.1.0",
"@metamask/phishing-controller": "^15.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Dependency Version Mismatch

The @metamask/phishing-controller dependency was updated from ^13.1.0 to ^15.0.0. This conflicts with the PR description, which states an update to 14.1.3. The ^15.0.0 version constraint will not accept 14.1.3, creating a mismatch between the intended and actual dependency version.

Additional Locations (2)

Fix in Cursor Fix in Web

"@metamask/object-multiplex": "^2.1.0",
"@metamask/permission-controller": "^12.0.0",
"@metamask/phishing-controller": "^13.1.0",
"@metamask/phishing-controller": "^15.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing Peer Dependency Causes Runtime Issues

The upgrade to @metamask/phishing-controller@^15.0.0 introduces a new peer dependency on @metamask/transaction-controller@^61.0.0. This dependency is currently missing across snaps-controllers, snaps-simulation, and snaps-jest, which could lead to runtime errors or unexpected behavior in these environments.

Additional Locations (2)

Fix in Cursor Fix in Web

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 28, 2025

Superseded by #3707.

@dependabot dependabot bot closed this Oct 28, 2025
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/main/metamask/phishing-controller-14.1.3 branch October 28, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants