-
Notifications
You must be signed in to change notification settings - Fork 637
chore: Bump @metamask/phishing-controller from 13.1.0 to 14.1.3 #3700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump @metamask/phishing-controller from 13.1.0 to 14.1.3 #3700
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3700 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 418 418
Lines 12152 12152
Branches 1876 1876
=======================================
Hits 11943 11943
Misses 209 209 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0045695 to
bc9a9dc
Compare
Bumps [@metamask/phishing-controller](https://github.com/MetaMask/core) from 13.1.0 to 14.1.3. - [Release notes](https://github.com/MetaMask/core/releases) - [Changelog](https://github.com/MetaMask/core/blob/main/docs/reviewing-release-prs.md) - [Commits](https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected]) --- updated-dependencies: - dependency-name: "@metamask/phishing-controller" dependency-version: 14.1.3 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
0edbb42 to
9c1c0dd
Compare
| "@metamask/object-multiplex": "^2.1.0", | ||
| "@metamask/permission-controller": "^12.0.0", | ||
| "@metamask/phishing-controller": "^13.1.0", | ||
| "@metamask/phishing-controller": "^15.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Dependency Version Mismatch
The @metamask/phishing-controller dependency was updated from ^13.1.0 to ^15.0.0. This conflicts with the PR description, which states an update to 14.1.3. The ^15.0.0 version constraint will not accept 14.1.3, creating a mismatch between the intended and actual dependency version.
Additional Locations (2)
| "@metamask/object-multiplex": "^2.1.0", | ||
| "@metamask/permission-controller": "^12.0.0", | ||
| "@metamask/phishing-controller": "^13.1.0", | ||
| "@metamask/phishing-controller": "^15.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing Peer Dependency Causes Runtime Issues
The upgrade to @metamask/phishing-controller@^15.0.0 introduces a new peer dependency on @metamask/transaction-controller@^61.0.0. This dependency is currently missing across snaps-controllers, snaps-simulation, and snaps-jest, which could lead to runtime errors or unexpected behavior in these environments.
Additional Locations (2)
|
Superseded by #3707. |
Bumps @metamask/phishing-controller from 13.1.0 to 14.1.3.
Commits
1577c9bRelease 641.0.0 (#6940)0867eaefeat: Add transaction emulation actions (#6935)7e387ebRelease/640.0.0 (#6934)77db789fix(core-backend): control randomness to fix flaky test (#6936)78fc4c3chore: Add@metamask-previews/*to NPM age gate exceptions (#6937)7305664Release/639.0.0 (#6931)ccb493efeat: make getCryptoApproveTransactionParams synchronous (#6930)796d640feat: add new actions toKeyringController(#6928)dfd2a80feat: addgetAccountstoAccountsController(#6927)d36cff6chore: removeMonad Mainnetsingle call balance contract and add into accou...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Note
Upgrades @metamask/phishing-controller to v15 across packages, updates lockfile, adds TextDecoder to LavaMoat policies, and refreshes example snap bundle shasums.
@metamask/phishing-controllerto^15.0.0inpackages/snaps-controllers,packages/snaps-simulation, and as a devDependency inpackages/snaps-jest; updateyarn.lockaccordingly (includes related transitive updates like@noble/hashes).TextDecoderglobal for@metamask/utils>@noble/hashesin LavaMoat policies foriframe,node-process,node-thread, andwebview.source.shasumin multiple example snap manifests (e.g.,bip32,bip44,cronjobs,dialogs,ethereum-provider,ethers-js,get-entropy,images,interactive-ui,invoke-snap/*,send-flow,signature-insights,transaction-insights).Written by Cursor Bugbot for commit ca2abc4. This will update automatically on new commits. Configure here.