Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Nov 5, 2025

Prevent a race condition in the preinstalled example Snap by using snap_setState.


Note

Use snap_setState for settings updates in the preinstalled example snap and update the manifest shasum.

  • Preinstalled example snap:
    • Replace settings input change flow to use snap_setState with key/value, removing prior snap_manageState get+update sequence.
  • Manifest:
    • Update source.shasum in packages/examples/packages/preinstalled/snap.manifest.json.

Written by Cursor Bugbot for commit 807ef4c. This will update automatically on new commits. Configure here.

@FrederikBolding FrederikBolding requested a review from a team as a code owner November 5, 2025 11:08
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.28%. Comparing base (e5f394c) to head (807ef4c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3725   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         418      418           
  Lines       12152    12152           
  Branches     1876     1876           
=======================================
  Hits        11943    11943           
  Misses        209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding added this pull request to the merge queue Nov 5, 2025
Merged via the queue into main with commit ab34f97 Nov 5, 2025
122 checks passed
@FrederikBolding FrederikBolding deleted the fb/prevent-race-condition-in-preinstalled-snap branch November 5, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants