feat!: Ensure user has onboarded before allowing usage of SnapController

[FrederikBolding]

Adds a new required constructor argument ensureOnboardingComplete. This should be a promise that resolves once the user has been onboarded. We can use this to ensure that a user has fully onboarded and decided whether to opt-out of Snaps before using Snaps at all. The function is used as part of assertCanUsePlatform.

---

Note

Require onboarding completion via new ensureOnboardingComplete hook and asynchronously gate Snap operations (install, start, handle requests, registry updates) until onboarding finishes.

• SnapController API:
  • Add required constructor hook ensureOnboardingComplete(): Promise<void> and store internally.
  • Make platform check async: #assertCanUsePlatform now awaits onboarding completion, then validates feature flags.
  • Await platform check in updateRegistry, startSnap, installSnaps, #updateSnap, and handleRequest.
• Tests:
  • Add test ensuring requests wait for onboarding completion before execution.
  • Update helpers to pass mocked ensureOnboardingComplete by default.
  • Adjust call-count expectations and minor timing in affected tests; remove a couple of unused delegated actions in test utils.

^{Written by Cursor Bugbot for commit dd19141. This will update automatically on new commits. Configure here.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.28%. Comparing base (c8affd0) to head (dd19141).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3731   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         418      418           
  Lines       12163    12177   +14     
  Branches     1881     1886    +5     
=======================================
+ Hits        11954    11968   +14     
  Misses        209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[FrederikBolding]

These seem to be changes in timing for when lifecycle hooks are called, due to the added async code we don't get as long in processing the side-effect before we reach the assertion.

[FrederikBolding]

This is a hack, but unsure how else to reproduce the race condition now

[Mrtenz]

Can we not get this from the onboarding controller state?

[FrederikBolding]

Unfortunately onboarding controller only exists on extension. On mobile the onboarding state is stored in Redux only, so we'll have to come up with a way to monitor that.