Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Nov 11, 2025

Allow updates of Snaps even when the disableSnapInstallation feature flag is enabled as long as the update is an automatic one.


Note

Permits automatic Snap updates to bypass the disableSnapInstallation check while preserving manual update restrictions for preinstalled Snaps.

  • Snaps Controller (SnapController.ts):
    • Modify #updateSnap(...) to only call #assertCanInstallSnaps() when automaticUpdate is false, allowing automatic updates even if disableSnapInstallation is enabled.
    • Retain restriction preventing manual updates of preinstalled Snaps (preinstalled && !automaticUpdate).

Written by Cursor Bugbot for commit 4c35eb4. This will update automatically on new commits. Configure here.

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.28%. Comparing base (e081eb2) to head (4c35eb4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3735   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         418      418           
  Lines       12162    12163    +1     
  Branches     1880     1881    +1     
=======================================
+ Hits        11953    11954    +1     
  Misses        209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding changed the title fix: Allow installs when using automatic updates fix: Override disableSnapInstallation feature flag when using automatic updates Nov 11, 2025
@FrederikBolding FrederikBolding marked this pull request as ready for review November 11, 2025 10:38
@FrederikBolding FrederikBolding requested a review from a team as a code owner November 11, 2025 10:38
@FrederikBolding FrederikBolding added this pull request to the merge queue Nov 11, 2025
Merged via the queue into main with commit ccf10b2 Nov 11, 2025
124 checks passed
@FrederikBolding FrederikBolding deleted the fb/allow-installs-during-automatic-updates branch November 11, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants