-
Notifications
You must be signed in to change notification settings - Fork 637
chore: Bump @metamask/phishing-controller from 15.0.0 to 16.1.0 #3748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump @metamask/phishing-controller from 15.0.0 to 16.1.0 #3748
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3748 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 418 418
Lines 12186 12186
Branches 1887 1887
=======================================
Hits 11977 11977
Misses 209 209 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2ac3442 to
d6d2629
Compare
| "@metamask/object-multiplex": "^2.1.0", | ||
| "@metamask/permission-controller": "^12.1.1", | ||
| "@metamask/phishing-controller": "^15.0.0", | ||
| "@metamask/phishing-controller": "^16.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing peer dependency for phishing controller upgrade
The upgrade to @metamask/phishing-controller@^16.1.0 introduces a peer dependency requirement for @metamask/transaction-controller@^62.0.0 (changed from ^61.0.0 in version 15.0.0). However, @metamask/transaction-controller is not listed as a dependency in any of the three packages (snaps-controllers, snaps-jest, snaps-simulation) that depend on the phishing controller. This unmet peer dependency will cause installation warnings or errors and potentially runtime issues if the phishing controller attempts to interact with the transaction controller.
Bumps [@metamask/phishing-controller](https://github.com/MetaMask/core) from 15.0.0 to 16.1.0. - [Release notes](https://github.com/MetaMask/core/releases) - [Changelog](https://github.com/MetaMask/core/blob/main/docs/reviewing-release-prs.md) - [Commits](https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected]) --- updated-dependencies: - dependency-name: "@metamask/phishing-controller" dependency-version: 16.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
d6d2629 to
20481f6
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Bumps @metamask/phishing-controller from 15.0.0 to 16.1.0.
Commits
2785995Release/689.0.0 (#7211)9d48697feat: export token scan types (#7208)7dda377Release/688.0.0 (#7207)a1c0fa8feat: gas station support for relay source transactions (#7193)acbb6c0feat: price API v3 upgrade (#7119)fcb43e6Release/687.0.0 (#7202)39f7d66add tron filtering options to token-selectors (#7198)85855a0fix:generate-method-action-typesworks for services as well (#7200)9e5d8c4Revert "Release 687.0.0" (#7201)b557946Release 687.0.0 (#7190)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Note
Upgrade
@metamask/phishing-controllerto16.1.0insnaps-controllers,snaps-jest, andsnaps-simulation, updating the lockfile and transitive dependencies.@metamask/phishing-controllerfrom^15.0.0to^16.1.0in:packages/snaps-controllers/package.jsonpackages/snaps-jest/package.json(devDependency)packages/snaps-simulation/package.jsonyarn.lockto@metamask/[email protected].@metamask/controller-utilsto^11.16.0and peer@metamask/transaction-controllerto^62.0.0.Written by Cursor Bugbot for commit 20481f6. This will update automatically on new commits. Configure here.