Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Dec 5, 2025

Bump snaps-registry to the latest version which changes verify to be async in order to use the global crypto digest API, which is much faster.


Note

Switches registry signature verification to async and bumps @metamask/snaps-registry to v4 for faster verification.

  • Snaps Controllers:
    • Make #verifySignature async; await verify and its call in #update.
  • Dependencies:
    • Bump @metamask/snaps-registry to ^4.0.0 in packages/snaps-controllers and packages/snaps-utils.

Written by Cursor Bugbot for commit 3a83139. This will update automatically on new commits. Configure here.

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.28%. Comparing base (e21d3a3) to head (3a83139).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3770   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         420      420           
  Lines       12211    12211           
  Branches     1889     1889           
=======================================
  Hits        12002    12002           
  Misses        209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​snaps-registry@​3.3.0 ⏵ 4.0.0100 +2100100 +12100 +13100

View full report

@FrederikBolding FrederikBolding marked this pull request as ready for review December 5, 2025 13:08
@FrederikBolding FrederikBolding requested a review from a team as a code owner December 5, 2025 13:08
@FrederikBolding FrederikBolding added this pull request to the merge queue Dec 5, 2025
Merged via the queue into main with commit f55d171 Dec 5, 2025
122 checks passed
@FrederikBolding FrederikBolding deleted the fb/async-verify-registry branch December 5, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants