fix: Bump default ping timeout #3773
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
commented
Dec 8, 2025
| it('throws an error if execution environment fails to respond to ping', async () => { | ||
| const { service } = createService(MockExecutionService); | ||
| const { service } = createService(MockExecutionService, { | ||
| pingTimeout: inMilliseconds(1, Duration.Second), |
Member
Author
There was a problem hiding this comment.
This test would run longer and exceed the Jest timeout without this
Mrtenz
approved these changes
Dec 8, 2025
cryptodev-2s
approved these changes
Dec 8, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3773 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 420 420
Lines 12211 12211
Branches 1889 1889
=======================================
Hits 12002 12002
Misses 209 209 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump default ping timeout to 10 seconds to improve stability on systems where initializing the Snaps Platform may take a bit of time.
Note
Increase default ping timeout to 10s and update tests to explicitly set a shorter timeout for ping failure behavior.
AbstractExecutionService: Bump defaultpingTimeoutfrom2sto10sin constructor.AbstractExecutionService.test.ts: ConfigurecreateServicewithpingTimeout: 1sfor the ping timeout failure test.Written by Cursor Bugbot for commit f2f1975. This will update automatically on new commits. Configure here.