diff --git a/packages/snaps-execution-environments/CHANGELOG.md b/packages/snaps-execution-environments/CHANGELOG.md index 0176b7ec96..2e02d2b122 100644 --- a/packages/snaps-execution-environments/CHANGELOG.md +++ b/packages/snaps-execution-environments/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Fixed + +- Add missing `includeMarketData` param to `onAssetsConversion` handler ([#3323](https://github.com/MetaMask/snaps/pull/3323)) + ## [7.2.0] ### Added diff --git a/packages/snaps-execution-environments/src/common/commands.test.ts b/packages/snaps-execution-environments/src/common/commands.test.ts index 068914e495..079a569bf2 100644 --- a/packages/snaps-execution-environments/src/common/commands.test.ts +++ b/packages/snaps-execution-environments/src/common/commands.test.ts @@ -41,6 +41,28 @@ describe('getHandlerArguments', () => { ).toThrow('Invalid request params'); }); + it('validates the request params for the OnAssetsConversion handler', () => { + expect(() => + getHandlerArguments(MOCK_ORIGIN, HandlerType.OnAssetsConversion, { + id: 1, + jsonrpc: '2.0', + method: 'foo', + params: {}, + }), + ).toThrow('Invalid request params'); + }); + + it('validates the request params for the OnAssetsLookup handler', () => { + expect(() => + getHandlerArguments(MOCK_ORIGIN, HandlerType.OnAssetsLookup, { + id: 1, + jsonrpc: '2.0', + method: 'foo', + params: {}, + }), + ).toThrow('Invalid request params'); + }); + it('validates the request params for the OnAssetHistoricalPrice handler', () => { expect(() => getHandlerArguments(MOCK_ORIGIN, HandlerType.OnAssetHistoricalPrice, { diff --git a/packages/snaps-execution-environments/src/common/commands.ts b/packages/snaps-execution-environments/src/common/commands.ts index 588c7fe8f4..333ab29897 100644 --- a/packages/snaps-execution-environments/src/common/commands.ts +++ b/packages/snaps-execution-environments/src/common/commands.ts @@ -74,8 +74,8 @@ export function getHandlerArguments( } case HandlerType.OnAssetsConversion: { assertIsOnAssetsConversionRequestArguments(request.params); - const { conversions } = request.params; - return { conversions }; + const { conversions, includeMarketData } = request.params; + return { conversions, includeMarketData }; } case HandlerType.OnNameLookup: { assertIsOnNameLookupRequestArguments(request.params);