From 807ef4c5d4a86b64d462dd1487d688a2ffebc845 Mon Sep 17 00:00:00 2001 From: Frederik Bolding Date: Wed, 5 Nov 2025 12:07:28 +0100 Subject: [PATCH] fix: Prevent race condition in preinstalled Snap --- .../packages/preinstalled/snap.manifest.json | 2 +- .../packages/preinstalled/src/index.tsx | 17 +++-------------- 2 files changed, 4 insertions(+), 15 deletions(-) diff --git a/packages/examples/packages/preinstalled/snap.manifest.json b/packages/examples/packages/preinstalled/snap.manifest.json index 776dea1239..9af75429a2 100644 --- a/packages/examples/packages/preinstalled/snap.manifest.json +++ b/packages/examples/packages/preinstalled/snap.manifest.json @@ -7,7 +7,7 @@ "url": "https://github.com/MetaMask/snaps.git" }, "source": { - "shasum": "5GjC5OYTtXLw1aHztViZ2Xf1dZIgvqP4xCgw4gPT1JY=", + "shasum": "BHcDBSLqllDgqbTjvlpoZLw5M13p4mK+d8b/yMMeHoU=", "location": { "npm": { "filePath": "dist/bundle.js", diff --git a/packages/examples/packages/preinstalled/src/index.tsx b/packages/examples/packages/preinstalled/src/index.tsx index 13cd69a2be..51dc440b8a 100644 --- a/packages/examples/packages/preinstalled/src/index.tsx +++ b/packages/examples/packages/preinstalled/src/index.tsx @@ -190,23 +190,12 @@ export const onUserInput: OnUserInputHandler = async ({ event.name === 'setting2' || event.name === 'setting3') ) { - const state = await snap.request({ - method: 'snap_manageState', - params: { - operation: 'get', - encrypted: false, - }, - }); - await snap.request({ - method: 'snap_manageState', + method: 'snap_setState', params: { - operation: 'update', encrypted: false, - newState: { - ...state, - [event.name]: event.value, - }, + key: event.name, + value: event.value, }, }); }