chore: add new error for bad options

Author: coodos

infrastructure/w3id/src/errors/errors.ts

@@ -5,3 +5,5 @@ export class MalformedHashChainError extends Error {}
 export class BadSignatureError extends Error {}
 
 export class BadNextKeySpecifiedError extends Error {}
+
+export class BadOptionsSpecifiedError extends Error {}

infrastructure/w3id/src/logs/log-manager.ts

@@ -1,13 +1,16 @@
 import canonicalize from "canonicalize";
 import {
 	BadNextKeySpecifiedError,
+	BadOptionsSpecifiedError,
 	BadSignatureError,
 	MalformedHashChainError,
 	MalformedIndexChainError,
 } from "../errors/errors";
 import { isSubsetOf } from "../utils/array";
 import { hash } from "../utils/hash";
 import {
+	isGenesisOptions,
+	isRotationOptions,
 	type CreateLogEventOptions,
 	type GenesisLogOptions,
 	type LogEvent,
@@ -135,8 +138,11 @@ export class IDLogManager {
 
 	async createLogEvent(options: CreateLogEventOptions) {
 		const entries = await this.repository.findMany({});
-		if (entries.length > 0)
-			return this.appendEntry(entries, options as RotationLogOptions);
-		return this.createGenesisEntry(options as GenesisLogOptions);
+		if (entries.length > 0) {
+			if (!isRotationOptions(options)) throw new BadOptionsSpecifiedError();
+			return this.appendEntry(entries, options);
+		}
+		if (!isGenesisOptions(options)) throw new BadOptionsSpecifiedError();
+		return this.createGenesisEntry(options);
 	}
 }

infrastructure/w3id/src/logs/log.types.ts

@@ -14,6 +14,11 @@ export type VerifierCallback = (
 	pubKey: string,
 ) => Promise<boolean>;
 
+export type Signer = {
+	sign: (string: string) => Promise<string> | string;
+	pubKey: string;
+};
+
 export type RotationLogOptions = {
 	nextKeyHashes: string[];
 	signer: Signer;
@@ -26,9 +31,15 @@ export type GenesisLogOptions = {
 	signer: Signer;
 };
 
-export type Signer = {
-	sign: (string: string) => Promise<string> | string;
-	pubKey: string;
-};
+export function isGenesisOptions(
+	options: CreateLogEventOptions,
+): options is GenesisLogOptions {
+	return "id" in options;
+}
+export function isRotationOptions(
+	options: CreateLogEventOptions,
+): options is RotationLogOptions {
+	return "nextKeySigner" in options;
+}
 
 export type CreateLogEventOptions = GenesisLogOptions | RotationLogOptions;