fix: coderabbit suggestions

Author: sosweetham

.vscode/settings.json

@@ -7,7 +7,21 @@
         "editor.defaultFormatter": "rust-lang.rust-analyzer",
         "editor.formatOnSave": true
     },
-    "[js,ts,svelte]": {
+    "[javascript]": {
+        "editor.defaultFormatter": "biomejs.biome",
+        "editor.codeActionsOnSave": {
+            "source.organizeImports.biome": "explicit",
+            "source.fixAll.biome": "explicit"
+        }
+    },
+    "[typescript]": {
+        "editor.defaultFormatter": "biomejs.biome",
+        "editor.codeActionsOnSave": {
+            "source.organizeImports.biome": "explicit",
+            "source.fixAll.biome": "explicit"
+        }
+    },
+    "[svelte]": {
         "editor.defaultFormatter": "biomejs.biome",
         "editor.codeActionsOnSave": {
             "source.organizeImports.biome": "explicit",

infrastructure/eid-wallet/src-tauri/src/lib.rs

@@ -7,26 +7,41 @@ mod funcs;
 //     format!("Hello, {}! You've been greeted from Rust!", name)
 // }
 
+/// Hashes a PIN using Argon2 with a random salt
+///
+/// # Arguments
+/// * `pin` - A string containing the user's PIN
+///
+/// # Returns
+/// * `Result<String, String>` - The hashed PIN string or an error message
 #[tauri::command]
 async fn hash(pin: String) -> Result<String, String> {
-    Ok(funcs::hash(pin).map_err(|err| err.to_string())?)
+    funcs::hash(pin).map_err(|err| format!("Failed to hash PIN: {}", err))
 }
 
+/// Verifies a PIN against a stored hash using Argon2
+///
+/// # Arguments
+/// * `pin` - A string containing the user's PIN to verify
+/// * `hash` - The stored hash to compare against
+///
+/// # Returns
+/// * `Result<bool, String>` - Whether the PIN matches the hash, or an error message
 #[tauri::command]
 async fn verify(pin: String, hash: String) -> Result<bool, String> {
-    Ok(funcs::verify(pin, hash).map_err(|err| err.to_string())?)
+    funcs::verify(pin, hash).map_err(|err| format!("Failed to verify PIN: {}", err))
 }
 
 #[cfg_attr(mobile, tauri::mobile_entry_point)]
 pub fn run() {
     tauri::Builder::default()
-        .plugin(tauri_plugin_barcode_scanner::init())
         .plugin(tauri_plugin_opener::init())
         .plugin(tauri_plugin_store::Builder::new().build())
         .setup(move |_app| {
             #[cfg(mobile)]
             {
                 _app.handle().plugin(tauri_plugin_biometric::init())?;
+                _app.handle().plugin(tauri_plugin_barcode_scanner::init())?;
             }
             Ok(())
         })

infrastructure/eid-wallet/src/lib/global/controllers/security.ts

@@ -130,6 +130,7 @@ export class SecurityController {
                 throw new Error("Invalid pin");
             }
             await this.#setPin(newPin);
+            return;
         }
         throw new Error("Old pin not provided!");
     }
@@ -189,7 +190,10 @@ export class SecurityController {
      * ```
      */
     set biometricSupport(value: boolean | Promise<boolean>) {
-        this.#setBiometric(value);
+        this.#setBiometric(value).catch((error) => {
+            console.error("Failed to set biometric support:", error);
+            // Consider how to handle errors in a setter - possibly notify via an event
+        });
     }
 
     /**

infrastructure/eid-wallet/src/lib/global/controllers/user.ts

@@ -54,19 +54,35 @@ export class UserController {
      * ```
      * @throws {Error} If the user state cannot be set in the store
      */
-    set user(user:
-        | Promise<Record<string, string> | undefined>
-        | Record<string, string>
-        | undefined) {
-        this.#store.set("user", user);
+    set user(
+        user:
+            | Promise<Record<string, string> | undefined>
+            | Record<string, string>
+            | undefined
+    ) {
+        if (user instanceof Promise) {
+            user.then((resolvedUser) => {
+                this.#store.set("user", resolvedUser);
+            }).catch((error) => {
+                console.error("Failed to set user:", error);
+            });
+        } else {
+            this.#store.set("user", user);
+        }
     }
 
     get user() {
-        return this.#store.get<Record<string, string>>("user").then((user) => {
-            if (!user) {
+        return this.#store
+            .get<Record<string, string>>("user")
+            .then((user) => {
+                if (!user) {
+                    return undefined;
+                }
+                return user;
+            })
+            .catch((error) => {
+                console.error("Failed to get user:", error);
                 return undefined;
-            }
-            return user;
-        });
+            });
     }
 }

infrastructure/eid-wallet/src/lib/ui/InputPin/InputPin.svelte

@@ -64,6 +64,7 @@ const changeHandler = (e: KeyboardEvent, i: number) => {
     const regx = /^\d+$/;
 
     if (isKeyDelete(e.key)) {
+        e.preventDefault()
         if (pins[i] !== "") {
             pins[i] = "";
             return;
@@ -75,12 +76,24 @@ const changeHandler = (e: KeyboardEvent, i: number) => {
     }
 
     if (regx.test(e.key)) {
+        e.preventDefault()
         pins[i] = e.key;
         if (currentIndex < items.length - 1) {
             newIndex = currentIndex + 1;
             (items[newIndex] as HTMLInputElement)?.focus();
         }
     }
+
+       // Allow arrow keys for navigation
+   if (e.key === 'ArrowLeft' && currentIndex > 0) {
+       newIndex = currentIndex - 1;
+       (items[newIndex] as HTMLInputElement)?.focus();
+   }
+
+   if (e.key === 'ArrowRight' && currentIndex < items.length - 1) {
+       newIndex = currentIndex + 1;
+       (items[newIndex] as HTMLInputElement)?.focus();
+   }
 };
 
 const createArray = (size: number) => {
@@ -125,7 +138,6 @@ const cBase =
           }}
           maxlength="1"
           onkeydown={(event) => {
-            event.preventDefault()
             changeHandler(event, i)
           }}
           placeholder=""

infrastructure/eid-wallet/src/routes/(app)/scan-qr/+page.svelte

@@ -59,6 +59,7 @@ async function startScan() {
         const formats = [Format.QRCode];
         const windowed = true;
 
+        if (scanning) return;
         scanning = true;
         scan({ formats, windowed })
             .then((res) => {
@@ -74,6 +75,9 @@ async function startScan() {
                 scanning = false;
             });
     }
+
+    console.error("Permission denied or not granted");
+    // TODO: consider handling GUI for permission denied
 }
 
 async function cancelScan() {

infrastructure/eid-wallet/src/routes/(auth)/login/+page.svelte

@@ -33,7 +33,11 @@ const authOpts: AuthOptions = {
 
 onMount(async () => {
     globalState = getContext<() => GlobalState>("globalState")();
-    if (!globalState) throw new Error("Global state is not defined");
+    if (!globalState) {
+        console.error("Global state is not defined");
+        await goto("/"); // Redirect to home or error page
+        return;
+    }
 
     clearPin = async () => {
         await globalState?.securityController.clearPin();
@@ -43,7 +47,7 @@ onMount(async () => {
     handlePinInput = async (pin: string) => {
         if (pin.length === 4) {
             isError = false;
-            const check = await globalState?.securityController.verifyPin(pin);
+            const check = globalState ? await globalState.securityController.verifyPin(pin) : false;
             if (!check) {
                 isError = true;
                 return;

infrastructure/eid-wallet/src/routes/(auth)/register/+page.svelte

@@ -72,7 +72,13 @@ onMount(async () => {
                 "Cannot set biometric support, Global state is not defined",
             );
         if (isBiometricsAvailable) {
-            globalState.securityController.biometricSupport = true;
+            try {
+                globalState.securityController.biometricSupport = true;
+            } catch (error) {
+                console.error("Failed to enable biometric support:", error);
+                // Consider showing an error message to the user
+                return;
+            }
         }
         isBiometricsAdded = true;
     };

infrastructure/eid-wallet/src/routes/(auth)/verify/+page.svelte

@@ -33,5 +33,12 @@ onMount(() => {
         />
         <img class="mx-auto mt-20" src="images/Passport.svg" alt="passport">
     </section>
-    <ButtonAction class="w-full" callback={async() => handleVerification()}>I'm ready</ButtonAction>
+    <ButtonAction class="w-full" callback={async() => {
+            try {
+                await handleVerification();
+            } catch (error) {
+                console.error("Verification failed:", error);
+                // Consider adding user-facing error handling here
+            }
+        }}>I'm ready</ButtonAction>
 </main>

infrastructure/eid-wallet/src/routes/+layout.svelte

@@ -38,7 +38,12 @@ onMount(async () => {
         };
     }
     runtime.biometry = status.biometryType;
-    globalState = await GlobalState.create();
+    try {
+        globalState = await GlobalState.create();
+    } catch (error) {
+        console.error("Failed to initialize global state:", error);
+        // Consider adding fallback behavior or user notification
+    }
 
     showSplashScreen = true; // Can't set up the original state to true or animation won't start
     navigationStack.push(window.location.pathname);