Chore/final fixes ms3 #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. WalkthroughIntroduces a cross-platform charter-signing feature set: new entities, services, APIs, mappings, storage/rules, and UI across Cerberus, Group Charter Manager (API and frontend), and eID Wallet. Refactors wallet scan/sign flows, updates Blabsy chat and storage/rules, adds mapping documentation and ontology schema, and adjusts configs. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant GCM_UI as Group Charter Manager UI
participant GCM_API as Group Charter Manager API
participant SignSvc as CharterSigningService
participant Wallet as eID Wallet
participant Cerb as Cerberus (Services)
User->>GCM_UI: Click "Sign Charter"
GCM_UI->>GCM_API: POST /api/signing/sessions (groupId, charterData)
GCM_API->>SignSvc: createSession(...)
SignSvc-->>GCM_API: sessionId, qrData, expiresAt
GCM_API-->>GCM_UI: session details
GCM_UI-->>User: Show QR / deep-link
User->>Wallet: Scan QR / Open deep-link (w3ds://sign...)
Wallet->>Wallet: Decode payload, ensure auth, sign message
Wallet->>GCM_API: POST /api/signing/callback (sessionId, signature, publicKey, message)
GCM_API->>SignSvc: processSignedPayload(...)
SignSvc->>GCM_API: CharterSigningResult (completed)
Note over GCM_API: Persist via CharterSignatureService
GCM_UI->>GCM_API: SSE GET /api/signing/sessions/:id/status
GCM_API-->>GCM_UI: event: signed (completed)
GCM_UI-->>User: Show success, refresh status
GCM_API->>Cerb: (async) analyze/notify via services
sequenceDiagram
autonumber
actor Person as User
participant Scan as Wallet Scan QR Page
participant Vault as Vault Controller
participant Redirect as External Redirect URI
Person->>Scan: Open Scan QR
Scan->>Scan: checkPermissions -> request if needed
alt Permissions granted
Scan->>Scan: start scanning
else
Scan-->>Person: Permission error state
end
Scan->>Scan: Detect deep-link (auth/sign) from sessionStorage or QR
alt Auth flow
Scan->>Vault: ensure authenticated vault
Scan-->>Redirect: redirect to auth callback
else Sign flow (poll/message)
Scan->>Vault: sign payload
Scan->>Redirect: POST signed payload
Redirect-->>Scan: response / redirect
end
Scan->>Scan: cleanup listeners on destroy
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (54)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Issue Number
Type of change
How the change has been tested
Change checklist
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Documentation
Chores