fix: pictique replay #338
Merged
fix: pictique replay #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. WalkthroughUpdates a UI label in a Svelte settings page. Enhances a web3 adapter subscriber by adding in-flight change deduplication via a pendingChanges map, delayed processing with safeguards, and a periodic cleanup routine removing stale entries. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant DB as DB Change Feed
participant Sub as Subscriber
participant Lock as Lock Checker
participant H as handleChange
participant Timer as Cleanup Timer
Note over Sub: Initialization
Timer->>Sub: setInterval(5m)
Sub->>Sub: cleanupOldPendingChanges(>10m)
Note over DB,Sub: Regular entity change
DB-->>Sub: onChange(tableName, id)
Sub->>Sub: changeKey = tableName:id
alt changeKey pending
Sub-->>DB: Skip (duplicate)
else not pending
Sub->>Sub: pendingChanges[changeKey] = now
Sub->>Sub: setTimeout(3s)
Sub-->>Sub: After 3s
Sub->>Lock: isLocked(globalId?)
alt locked
Sub-->>Sub: Skip processing
else unlocked
Sub->>H: handleChange(tableName, id)
end
Sub->>Sub: finally: delete pendingChanges[changeKey]
end
Note over DB,Sub: Junction table change
DB-->>Sub: onJunctionChange(entity, parentId)
Sub->>Sub: changeKey = junction:entity:parentId
alt changeKey pending
Sub-->>DB: Skip (duplicate)
else not pending
Sub->>Sub: pendingChanges[changeKey] = now
Sub->>Sub: setTimeout(3s)
Sub-->>Sub: After 3s
Sub->>Lock: isLocked(globalId of parent?)
alt locked
Sub-->>Sub: Skip processing
else unlocked
Sub->>H: handleChange(entity, parentId)
end
Sub->>Sub: finally: delete pendingChanges[changeKey]
end
Note over Timer,Sub: Periodic cleanup logs purged keys
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (2)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Issue Number
Type of change
How the change has been tested
Change checklist
Summary by CodeRabbit
Chores
Bug Fixes