Do not use in param in NBitcoin.Secp256k1 (Fix #1289)

Author: NicolasDorier

NBitcoin.Secp256k1/NBitcoin.Secp256k1.csproj

@@ -12,7 +12,7 @@
 	</PropertyGroup>
   <PropertyGroup>
     <TargetFrameworks>net6.0;netstandard2.1</TargetFrameworks>
-    <Version Condition=" '$(Version)' == '' ">3.1.6</Version>
+    <Version Condition=" '$(Version)' == '' ">3.2.0</Version>
   </PropertyGroup>
   <PropertyGroup>
     <DefineConstants>$(DefineConstants);SECP256K1_LIB;HAS_SPAN</DefineConstants>

NBitcoin/Secp256k1/ECPubKey.cs

@@ -401,25 +401,9 @@ public ECPubKey GetSharedPubkey(ECPrivKey key)
 			Secp256k1.GE pt = this.Q;
 			ref readonly Secp256k1.Scalar s = ref key.sec;
 			key.AssertNotDisposed();
-			// Can't happen, NBitcoin enforces invariants.
-			//secp256k1_scalar_set_b32(&s, scalar, &overflow);
-			//if (overflow || secp256k1_scalar_is_zero(&s))
-			//{
-			//	ret = 0;
-			//}
-			Span<byte> x = stackalloc byte[32];
-			Span<byte> y = stackalloc byte[32];
-
 			res = pt.MultConst(s, 256);
 			pt = res.ToGroupElement();
-
 			return new ECPubKey(new GE(pt.x.Normalize(), pt.y.Normalize()), ctx);
-			/* Compute a hash of the point */
-			//ret = hashfp(output, x, y, data);
-
-			// We have a ref over an undisposed secret here
-			//secp256k1_scalar_clear(&s);
-			//return ret;
 		}
 
 		internal static int secp256k1_memcmp_var(ReadOnlySpan<byte> s1, ReadOnlySpan<byte> s2, int n)

NBitcoin/Secp256k1/GE.cs

@@ -181,13 +181,13 @@ public readonly GE MultiplyLambda()
 			return new GE(x * beta, y, infinity);
 		}
 
-		public GE(in FE x, in FE y, bool infinity)
+		public GE(FE x, FE y, bool infinity)
 		{
 			this.x = x;
 			this.y = y;
 			this.infinity = infinity;
 		}
-		public GE(in FE x, in FE y)
+		public GE(FE x, FE y)
 		{
 			this.x = x;
 			this.y = y;

NBitcoin/Secp256k1/GEJ.cs

@@ -41,14 +41,14 @@ public static GEJ CONST(uint a, uint b, uint c, uint d, uint e, uint f, uint g,
 				);
 		}
 
-		public GEJ(in FE x, in FE y, in FE z, bool infinity)
+		public GEJ(FE x, FE y, FE z, bool infinity)
 		{
 			this.x = x;
 			this.y = y;
 			this.z = z;
 			this.infinity = infinity;
 		}
-		public GEJ(in FE x, in FE y, in FE z)
+		public GEJ(FE x, FE y, FE z)
 		{
 			this.x = x;
 			this.y = y;