OptInRBF was not setting NonFinalSequenceSet

NicolasDorier · NicolasDorier · commit e5628f281cca · 2019-04-24T15:47:21.000+09:00
diff --git a/NBitcoin.Tests/transaction_tests.cs b/NBitcoin.Tests/transaction_tests.cs
@@ -1744,6 +1744,7 @@ public void CanBuildTransaction()
 				.SendFees(Money.Parse("0.0001"))
 				.SetChange(destinations[3])
 				.BuildTransaction(true);
+			Assert.False(tx.RBF);
 			Assert.True(txBuilder.Verify(tx, "0.0001"));
 
 			// Let's check if PSBT can be finalized
diff --git a/NBitcoin/TransactionBuilder.cs b/NBitcoin/TransactionBuilder.cs
@@ -1427,6 +1427,7 @@ private IEnumerable<ICoin> BuildTransaction(
 				if(OptInRBF)
 				{
 					input.Sequence = Sequence.OptInRBF;
+					ctx.NonFinalSequenceSet = true;
 				}
 				if(_LockTime != null && !ctx.NonFinalSequenceSet)
 				{

Original file line number	Diff line number	Diff line change
`@@ -1427,6 +1427,7 @@ private IEnumerable<ICoin> BuildTransaction(`
`1427`	`1427`	`if(OptInRBF)`
`1428`	`1428`	`{`
`1429`	`1429`	`input.Sequence = Sequence.OptInRBF;`
	`1430`	`+ ctx.NonFinalSequenceSet = true;`
`1430`	`1431`	`}`
`1431`	`1432`	`if(_LockTime != null && !ctx.NonFinalSequenceSet)`
`1432`	`1433`	`{`