Bump Bitcoin Core to 27.1 (#1247)

* Bump Bitcoin Core to 27.1

* Fix TestMempoolAccept's MaxFeeRate

Author: NicolasDorier

NBitcoin.TestFramework/WellknownNodeDownloadData.cs

@@ -448,6 +448,34 @@ public class BitcoinNodeDownloadData : NodeDownloadDataBase
 				UseSectionInConfigFile = true,
 				CreateWallet = true
 			};
+
+			public NodeDownloadData v27_1 = new NodeDownloadData()
+			{
+				Version = "27.1",
+				Linux = new NodeOSDownloadData()
+				{
+					Archive = "bitcoin-{0}-x86_64-linux-gnu.tar.gz",
+					DownloadLink = "https://bitcoincore.org/bin/bitcoin-core-{0}/bitcoin-{0}-x86_64-linux-gnu.tar.gz",
+					Executable = "bitcoin-{0}/bin/bitcoind",
+					Hash = "c9840607d230d65f6938b81deaec0b98fe9cb14c3a41a5b13b2c05d044a48422"
+				},
+				Mac = new NodeOSDownloadData()
+				{
+					Archive = "bitcoin-{0}-x86_64-apple-darwin.tar.gz",
+					DownloadLink = "https://bitcoincore.org/bin/bitcoin-core-{0}/bitcoin-{0}-x86_64-apple-darwin.tar.gz",
+					Executable = "bitcoin-{0}/bin/bitcoind",
+					Hash = "6d94bde5541a18964c1c36b0f12334004e45e195f244e381fd459827b1fdc395"
+				},
+				Windows = new NodeOSDownloadData()
+				{
+					Executable = "bitcoin-{0}/bin/bitcoind.exe",
+					DownloadLink = "https://bitcoincore.org/bin/bitcoin-core-{0}/bitcoin-{0}-win64.zip",
+					Archive = "bitcoin-{0}-win64.zip",
+					Hash = "9719871a2c9a45c741e33d670d2319dcd3f8f52a6059e9c435a9a2841188b932"
+				},
+				UseSectionInConfigFile = true,
+				CreateWallet = true
+			};
 		}
 
 		public class LitecoinNodeDownloadData : NodeDownloadDataBase

NBitcoin.Tests/RPCClientTests.cs

@@ -1915,7 +1915,10 @@ public void ShouldWalletProcessPSBTAndExtractMempoolAcceptableTX()
 				tx = builder.Network.CreateTransaction();
 				foreach (var coin in spendableCoins)
 					tx.Inputs.Add(coin.Outpoint);
+				var total = spendableCoins.Sum(c => c.Amount);
 				tx.Outputs.Add(new TxOut(Money.Coins(45), kOut));
+				// Change output
+				tx.Outputs.Add(new TxOut(total - Money.Coins(45) - Money.Satoshis(5000), spendableCoins.First().ScriptPubKey));
 				var psbtUnFinalized = PSBT.FromTransaction(tx, builder.Network);
 
 				var type = SigHash.All;
@@ -1939,8 +1942,12 @@ public void ShouldWalletProcessPSBTAndExtractMempoolAcceptableTX()
 				result.PSBT.Finalize();
 
 				var txResult = result.PSBT.ExtractTransaction();
-				var acceptResult = client.TestMempoolAccept(txResult, new TestMempoolParameters() { MaxFeeRate = new FeeRate(10_000m) });
+				var estimatedFeeRate = result.PSBT.GetEstimatedFeeRate();
+				var acceptResult = client.TestMempoolAccept(txResult, new TestMempoolParameters() { MaxFeeRate = new FeeRate(estimatedFeeRate.FeePerK + new Money(1)) });
 				Assert.True(acceptResult.IsAllowed, acceptResult.RejectReason);
+				acceptResult = client.TestMempoolAccept(txResult, new TestMempoolParameters() { MaxFeeRate = new FeeRate(estimatedFeeRate.FeePerK - Money.Satoshis(10)) });
+				Assert.False(acceptResult.IsAllowed, acceptResult.RejectReason);
+				Assert.Equal("max-fee-exceeded", acceptResult.RejectReason);
 			}
 		}
 

NBitcoin/RPC/RPCClient.cs

@@ -1724,7 +1724,7 @@ public async Task<MempoolAcceptResult> TestMempoolAcceptAsync(Transaction transa
 			{
 				try
 				{
-					var feeRateDecimal = feeRate.FeePerK.ToDecimal(MoneyUnit.Satoshi);
+					var feeRateDecimal = feeRate.FeePerK.ToDecimal(MoneyUnit.BTC);
 					response = await SendCommandAsync(RPCOperations.testmempoolaccept, cancellationToken, new[] { transaction.ToHex() }, feeRateDecimal).ConfigureAwait(false);
 				}
 				catch (RPCException ex) when (ex.Message == "Expected type bool, got number")