Refactor tests using bats assertions and how it is done in other aljibe addons

Author: rsanzante

tests/test.bats

@@ -1,35 +1,45 @@
+#!/usr/bin/env bats
+
+# Standard DDEV add-on setup code taken from official DDEV add-ons.
 setup() {
   set -eu -o pipefail
-  export DIR="$( cd "$( dirname "$BATS_TEST_FILENAME" )" >/dev/null 2>&1 && pwd )/.."
-  export TESTDIR=~/tmp/test-mkdocs
-  mkdir -p $TESTDIR
-  export PROJNAME=test-mkdocs
-  export DDEV_NON_INTERACTIVE=true
-  ddev delete -Oy ${PROJNAME} >/dev/null 2>&1 || true
+  export GITHUB_REPO=Metadrop/ddev-aljibe-assistant
+  TEST_BREW_PREFIX="$(brew --prefix 2>/dev/null || true)"
+  export BATS_LIB_PATH="${BATS_LIB_PATH}:${TEST_BREW_PREFIX}/lib:/usr/lib/bats"
+  bats_load_library bats-assert
+  bats_load_library bats-file
+  bats_load_library bats-support
+
+  # shellcheck disable=SC2155
+  export DIR="$(cd "$(dirname "${BATS_TEST_FILENAME}")/.." >/dev/null 2>&1 && pwd)"
+  # shellcheck disable=SC2155
+  export PROJNAME="test-$(basename "${GITHUB_REPO}")"
+
+  mkdir -p ~/tmp
+  # shellcheck disable=SC2155
+  export TESTDIR=$(mktemp -d ~/tmp/${PROJNAME}.XXXXXX)
+  export DDEV_NONINTERACTIVE=true
+  export DDEV_NO_INSTRUMENTATION=true
+  ddev delete -Oy "${PROJNAME}" >/dev/null 2>&1 || true
+
   cd "${TESTDIR}"
-  ddev config --project-name=${PROJNAME}
-  ddev get metadrop/ddev-aljibe
-  ddev start -y >/dev/null
-  ddev aljibe-assistant --auto
+  run ddev config --project-name="${PROJNAME}" --project-tld=ddev.site
+  assert_success
+  run ddev start -y
+  assert_success
 }
 
 health_checks() {
   echo "Checking mkdocs health" >&3
-  ddev exec wget http://mkdocs:8000 -q -O - | grep Welcome | grep -m1 "Welcome to Mkdocs"
+  run ddev exec wget http://mkdocs:8000 -q -O -
+  assert_output --partial "Welcome to MkDocs"
 }
 
 check_build_mkdocs() {
   echo "Checking mkdocs build" >&3
   ddev mkdocs build
 }
 
-t() {
-  set -eu -o pipefail
-  cd ${TESTDIR} || ( printf "unable to cd to ${TESTDIR}\n" && exit 1 )
-  ddev delete -Oy ${PROJNAME} >/dev/null 2>&1
-  [ "${TESTDIR}" != "" ] && rm -rf ${TESTDIR}
-}
-
 @test "Install from folder" {
   set -eu -o pipefail
   cd ${TESTDIR}
@@ -38,6 +48,8 @@ t() {
   echo "Installed add-on from directory, restarting ddev" >&3
   ddev restart
   echo "Testing mkdocs" >&3
+
   health_checks
+
   check_build_mkdocs
 }