Skip to content

Closes #22 Startup description for SnakeGame #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Closes #22 Startup description for SnakeGame #75

wants to merge 5 commits into from

Conversation

Spencer-Church
Copy link
Collaborator

Closes #22

Added a startup description for SnakeGame.java

-Spencer Church @Spencer-Church

@jody jody added the Games Associated with Games project label Apr 15, 2025
@jody jody moved this from Ready to In review in CS3250 Spring2025 Console Game Hub Apr 15, 2025
@jody
Copy link
Contributor

jody commented Apr 15, 2025

Please ask someone to add a comment to this PR offering to be a reviewer.

@jody jody self-requested a review April 15, 2025 16:16
jody
jody requested changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@jody jody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the Checkstyle report for the proposed SnakeGame.java file.
Screenshot 2025-04-15 at 10 27 01 AM

The errors on line 16 were in the original and do not need to be addressed in this PR.

All other errors were introduced by the changes made by this PR and need to be fixed: convert all tab characters to spaces and break lines into liens of smaller lengths.

Please ask a colleague to add a comment to this PR indicating that they will review the changes.

@jody jody mentioned this pull request Apr 17, 2025
Open
@Spencer-Church
Copy link
Collaborator Author

Resolves #22 Fixed check style issues. I am workin on getting a contributor to review code

@jody jody requested a review from Copilot April 22, 2025 15:25
Copilot
Copilot AI reviewed Apr 22, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces an updated startup description for SnakeGame by replacing the placeholder message with detailed console output.

  • Reformatted the getName method.
  • Added multiple System.out.println statements describing the game rules.

jody
jody requested changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@jody jody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the Checkstyle-identified coding convention errors.
Here is the current report.
Screenshot 2025-04-22 at 9 28 37 AM

@FernandoRP1
Copy link
Collaborator

Please ask someone to add a comment to this PR offering to be a reviewer.

I can review his PR
@FernandoRP1

@jody jody requested a review from FernandoRP1 April 26, 2025 21:43
jody
jody requested changes May 7, 2025
View reviewed changes
Copy link
Contributor

@jody jody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runtime behavior is good!
Regression testing is fine (no changes).

Only change requested is removal of a misplaced comment.

SnakeGame.java
Comment on lines +19 to +23
/**
*Added print statements that give user
*a descripton of how to play SnakeGame.java
*@return Placeholder
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be more of a "Commit message" than a source code comment. Please delete.

@jody jody removed the request for review from FernandoRP1 May 10, 2025 18:32
@jody jody moved this from Ready to In review in CS3250 Spring2025 Console Game Hub May 10, 2025
@jody jody moved this from In review to Ready in CS3250 Spring2025 Console Game Hub May 21, 2025
@jody jody marked this pull request as draft May 21, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@jody jody jody requested changes

Assignees

@Spencer-Church Spencer-Church

Labels
Games Associated with Games project
Projects
CS3250 Spring2025 Console Game Hub
Status: Ready
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[USER STORY] Add startup description for Snake
3 participants
@Spencer-Church @jody @FernandoRP1