Merge pull request #1 from MhouneyLH/feat/nbomber_prefix

Feat/nbomber prefix

Author: MhouneyLH

README.md

@@ -107,6 +107,12 @@ NBomberRunner
 
 For more code samples and examples, please refer to the [samples](samples) directory.
 
+## Known Issues & Limitations
+
+When using Rider and want or any other ide and try to start with a "green play button" it will not work when using `LoadInfraConfig`, please create Program.cs with Main method and run from terminal using `dotnet run`
+
+The export interval is currently fixed to the OtelExporter default of `60` seconds and cannot be changed via configuration (the only thing that can be changed is the reporting interval in NBomber using `WithReportingInterval` which is independent from the export interval)
+
 ## Contributing
 
 Contributions are welcome! If you find a bug or want to add a new feature, please open an issue or submit a pull request. Happy coding! 🎉

src/NBomber.Sinks.Otel/AppDiagnostics.cs

@@ -6,23 +6,27 @@ namespace NBomber.Sinks.Otel;
 
 internal static class AppDiagnostics
 {
+    private const string MetricPrefix = "nbomber_";
+
+    private static string PrefixMetric(string name) => $"{MetricPrefix}{name}";
+
     internal static readonly string AssemblyVersion =
         typeof(AppDiagnostics).Assembly.GetCustomAttribute<AssemblyInformationalVersionAttribute>()?.InformationalVersion
         ?? typeof(AppDiagnostics).Assembly.GetName().Version!.ToString();
 
     internal static readonly Meter Meter = new("NBomber.Sinks.Otel", AssemblyVersion);
 
-    internal static readonly SynchronousGauge<int> NodeCount = new(Meter, "cluster.node_count", description: "Number of nodes involved in the test run");
-    internal static readonly SynchronousGauge<int> CpuCount = new(Meter, "cluster.node_cpu_count", description: "Number of CPU cores involved in the test run");
+    internal static readonly SynchronousGauge<int> NodeCount = new(Meter, PrefixMetric("cluster.node_count"), description: "Number of nodes involved in the test run");
+    internal static readonly SynchronousGauge<int> CpuCount = new(Meter, PrefixMetric("cluster.node_cpu_count"), description: "Number of CPU cores involved in the test run");
 
-    internal static readonly Histogram<double> SuccessfulRequestLatency = Meter.CreateHistogram<double>("ok.request.latency", description: "Latency for successful requests", unit: "ms");
-    internal static readonly Histogram<double> FailedRequestLatency = Meter.CreateHistogram<double>("fail.request.latency", description: "Latency for failed requests", unit: "ms");
+    internal static readonly Histogram<double> SuccessfulRequestLatency = Meter.CreateHistogram<double>(PrefixMetric("ok.request.latency"), description: "Latency for successful requests", unit: "ms");
+    internal static readonly Histogram<double> FailedRequestLatency = Meter.CreateHistogram<double>(PrefixMetric("fail.request.latency"), description: "Latency for failed requests", unit: "ms");
 
     internal static void SetUsersCount(double value, params KeyValuePair<string, object?>[]? tags)
     {
         const string name = "users.count";
 
-        Gauge(name, null, null, value, tags);
+        Gauge(PrefixMetric(name), null, null, value, tags);
     }
 
     internal static void SetTotalRps(double value, params KeyValuePair<string, object?>[]? tags)
@@ -31,7 +35,7 @@ internal static void SetTotalRps(double value, params KeyValuePair<string, objec
         const string unit = "req/s";
         const string description = "Number of requests per second for the step";
 
-        Gauge(name, unit, description, value, tags);
+        Gauge(PrefixMetric(name), unit, description, value, tags);
     }
 
     internal static void SetSuccessfulRps(double value, params KeyValuePair<string, object?>[]? tags)
@@ -40,7 +44,7 @@ internal static void SetSuccessfulRps(double value, params KeyValuePair<string,
         const string unit = "req/s";
         const string description = "Number of successful requests per second for the step";
 
-        Gauge(name, unit, description, value, tags);
+        Gauge(PrefixMetric(name), unit, description, value, tags);
     }
 
     internal static void SetFailedRps(double value, params KeyValuePair<string, object?>[]? tags)
@@ -49,28 +53,28 @@ internal static void SetFailedRps(double value, params KeyValuePair<string, obje
         const string unit = "req/s";
         const string description = "Number of failed requests per second for a step";
 
-        Gauge(name, unit, description, value, tags);
+        Gauge(PrefixMetric(name), unit, description, value, tags);
     }
 
     internal static void SetTotalRequestsCount(double value, params KeyValuePair<string, object?>[]? tags)
     {
         const string name = "all.request.count";
 
-        Gauge(name, null, null, value, tags);
+        Gauge(PrefixMetric(name), null, null, value, tags);
     }
 
     internal static void SetSuccessfulRequestsCount(double value, KeyValuePair<string, object?>[] tags)
     {
         const string name = "ok.request.count";
 
-        Gauge(name, null, null, value, tags);
+        Gauge(PrefixMetric(name), null, null, value, tags);
     }
 
     internal static void SetFailedRequestsCount(double value, KeyValuePair<string, object?>[] tags)
     {
         const string name = "fail.request.count";
 
-        Gauge(name, null, null, value, tags);
+        Gauge(PrefixMetric(name), null, null, value, tags);
     }
 
 

src/NBomber.Sinks.Otel/FileExporter.cs

@@ -53,7 +53,6 @@ public override ExportResult Export(in Batch<Metric> batch)
                                 sb.Append($"Gauge: {dataPoint.GetGaugeLastValueDouble()} | ");
                                 break;
                             case MetricType.Histogram:
-                                var histogram = dataPoint.GetHistogramBuckets();
                                 sb.Append($"Histogram - Count: {dataPoint.GetHistogramCount()}, Sum: {dataPoint.GetHistogramSum()} | ");
                                 break;
                             default: