nixpkgs-review does not refetch fixed output derivations

[Pandapip1]

Cached sources can result in false build successes. See NixOS/nixpkgs#316975 (comment)

[Mic92]

It feels like this is a bit out of hand of what nixpkgs-review can achieve. The bigger problem here is that nix finds the source code being cached and we have no way of telling from the nixpkg-review perspective if something should get rebuild i.e. if there is a new, very different url but with the same checksum.

I don't really know how much storage we actually save from occasional de-duplication, but sometimes it feels like it would be better to have a pkgs.fetchurl two, which also tries to include some basename into the target url to avoid this issue for most practical usecases.

[Pandapip1]

sometimes it feels like it would be better to have a pkgs.fetchurl two, which also tries to include some basename into the target url to avoid this issue for most practical usecases

That wouldn't fix the error in this case. This instance was link rot due to a repository migration.

I did some looking around and apparently there isn't a --refetch-fixed-outputs or equivalent option anywhere? That seems like it should already have been proposed by now. I'll open a related issue in the nix repo.

[SuperSandro2000]

We could try building .src with --rebuild or for eg buildGoModule .goModules

[Pandapip1]

What about derivations that use .srcs? As far as I'm aware, there's not a way to individually index srcs and build them all from the command line.

For the time being though, rebuilding .src does seem to be a good idea.