Auto detect network name server changes (#66)

* Using `NetworkChange` event to react on changing network adapters
* Periodically re-run `NameServer.ResolveNameServers` to check if the configuration changed

Author: MichaCo

README.md

@@ -1,8 +1,9 @@
 # DnsClient.NET
 
-[![Build Status](https://dev.azure.com/michaco/DnsClient/_apis/build/status/MichaCo.DnsClient.NET?branchName=dev)](https://dev.azure.com/michaco/DnsClient/_build/latest?definitionId=1&branchName=dev)
-[![NuGet](https://img.shields.io/nuget/v/DnsClient.svg?style=flat&label=Stable)](https://www.nuget.org/packages/DnsClient) 
-[![MyGet](https://img.shields.io/myget/dnsclient/vpre/DnsClient.svg?style=flat&label=Pre-release)](https://www.myget.org/feed/dnsclient/package/nuget/DnsClient) 
+[![Build Status](https://dev.azure.com/michaco/DnsClient/_apis/build/status/MichaCo.DnsClient.NET?branchName=dev&label=Build)](https://dev.azure.com/michaco/DnsClient/_build/latest?definitionId=1&branchName=dev)
+[![Code Coverage](https://img.shields.io/azure-devops/coverage/michaco/DnsClient/1?label=Coverage&style=flat&color=informational)](https://dev.azure.com/michaco/DnsClient/_build/latest?definitionId=1&branchName=dev)
+[![NuGet](https://img.shields.io/nuget/v/DnsClient?color=brightgreen&label=NuGet%20Stable)](https://www.nuget.org/packages/DnsClient)
+[![NuGet](https://img.shields.io/nuget/vpre/DnsClient?color=yellow&label=NuGet%20Latest)](https://www.nuget.org/packages/DnsClient) 
 
 DnsClient.NET is a simple yet very powerful and high performant open source library for the .NET Framework to do DNS lookups.
 

azure-pipelines-ci.yml

@@ -48,25 +48,26 @@ jobs:
 
   steps:
   - task: DotNetCoreCLI@2
+    displayName: 'dotnet build'
     inputs:
       command: 'build'
       projects: |
         src/**/*.csproj
         test/DnsClient.Tests/*.csproj
       arguments: '-c Release'
-    name: 'Build'
-    displayName: 'dotnet build'
+    name: 'Build'    
   - task: DotNetCoreCLI@2
+    displayName: "dotnet test"
     inputs:
       command: 'test'
       projects: 'test/DnsClient.Tests/*.csproj'
-      publishTestResults: true
-      arguments: '-c Release --no-build --no-restore'
-
+      publishTestResults: true      
+      arguments: '-c Release --no-build --no-restore --collect "Code coverage"'
   - script: 'dotnet pack src\DnsClient\DnsClient.csproj -c Release --no-build --no-restore --version-suffix $(versionSuffix) -v normal -o $(Build.ArtifactStagingDirectory)'
     name: 'PackBeta'
-    displayName: 'dotnet pack for beta'
+    displayName: 'dotnet pack'
   - task: PublishBuildArtifacts@1
+    displayName: 'publish'
     inputs:
       pathtoPublish: '$(Build.ArtifactStagingDirectory)' 
       artifactName: 'beta'

samples/MiniDig/PerfCommand.cs

@@ -12,6 +12,7 @@ namespace DigApp
     public class PerfCommand : DnsCommand
     {
         private int _clients;
+        private int _tasks;
         private string _query;
         private int _runtime;
         private long _reportExcecutions = 0;
@@ -26,6 +27,8 @@ public class PerfCommand : DnsCommand
 
         public CommandOption ClientsArg { get; private set; }
 
+        public CommandOption TasksArg { get; private set; }
+
         public CommandArgument QueryArg { get; private set; }
 
         public CommandOption RuntimeArg { get; private set; }
@@ -40,6 +43,7 @@ protected override void Configure()
         {
             QueryArg = App.Argument("query", "the domain query to run.", false);
             ClientsArg = App.Option("-c | --clients", "Number of clients to run", CommandOptionType.SingleValue);
+            TasksArg = App.Option("--tasks", "Number of tasks each client runs simultanously (8).", CommandOptionType.SingleValue);
             RuntimeArg = App.Option("-r | --run", "Time in seconds to run", CommandOptionType.SingleValue);
             SyncArg = App.Option("--sync", "Run synchronous api", CommandOptionType.NoValue);
             base.Configure();
@@ -48,6 +52,17 @@ protected override void Configure()
         protected override async Task<int> Execute()
         {
             _clients = ClientsArg.HasValue() ? int.Parse(ClientsArg.Value()) : 10;
+            if (_clients <= 0)
+            {
+                throw new ArgumentOutOfRangeException(nameof(ClientsArg));
+            }
+
+            _tasks = TasksArg.HasValue() ? int.Parse(TasksArg.Value()) : 8;
+            if (_clients <= 0)
+            {
+                throw new ArgumentOutOfRangeException(nameof(TasksArg));
+            }
+
             _runtime = RuntimeArg.HasValue() ? int.Parse(RuntimeArg.Value()) <= 1 ? 5 : int.Parse(RuntimeArg.Value()) : 5;
             _query = string.IsNullOrWhiteSpace(QueryArg.Value) ? string.Empty : QueryArg.Value;
             _runSync = SyncArg.HasValue();
@@ -57,7 +72,7 @@ protected override async Task<int> Execute()
             _lookup = GetDnsLookup(_settings);
             _running = true;
 
-            Console.WriteLine($"; <<>> Starting perf run with {_clients} clients running for {_runtime} seconds <<>>");
+            Console.WriteLine($"; <<>> Starting perf run with {_clients} (x{_tasks}) clients running for {_runtime} seconds <<>>");
             Console.WriteLine($"; ({_settings.NameServers.Count} Servers, caching:{_settings.UseCache}, minttl:{_settings.MinimumCacheTimeout?.TotalMilliseconds}, maxttl:{_settings.MaximumCacheTimeout?.TotalMilliseconds})");
             _spinner = new Spiner();
             _spinner.Start();
@@ -76,7 +91,7 @@ protected override async Task<int> Execute()
 
             for (var clientIndex = 0; clientIndex < _clients; clientIndex++)
             {
-                tasks.Add(ExcecuteRun());
+                tasks.Add(ExcecuteRun(numTasks: _tasks));
             }
 
             tasks.Add(CollectPrint());
@@ -91,7 +106,7 @@ protected override async Task<int> Execute()
             Console.WriteLine(string.Join("-", Enumerable.Repeat("-", 50)));
             Console.WriteLine($";; results:\t\t");
             Console.WriteLine(string.Join("-", Enumerable.Repeat("-", 50)));
-            Console.WriteLine($";; run for {elapsedSeconds}sec {_clients} clients.");
+            Console.WriteLine($";; run for {elapsedSeconds}sec {_clients} (x{_tasks}) clients.");
 
             var successPercent = _errors == 0 ? 100 : _success == 0 ? 0 : (100 - ((double)_errors / (_success) * 100));
             Console.WriteLine($";; {_errors:N0} errors {_success:N0} ok {successPercent:N2}% success.");
@@ -115,14 +130,25 @@ private async Task CollectPrint()
             _running = false;
         }
 
-        private async Task ExcecuteRun()
+        private async Task ExcecuteRun(int numTasks = 8)
         {
             //var swatch = Stopwatch.StartNew();
             var options = GetLookupSettings();
             options.EnableAuditTrail = false;
             var lookup = GetDnsLookup(options);
 
             while (_running)
+            {
+                var tasks = new List<Task>();
+                for (var i = 0; i < numTasks; i++)
+                {
+                    tasks.Add(Job());
+                }
+
+                await Task.WhenAll(tasks);
+            }
+
+            async Task Job()
             {
                 try
                 {

src/DnsClient/DnsQueryOptions.cs

@@ -851,102 +851,6 @@ public bool Equals(LookupClientSettings other)
                 && Equals(MaximumCacheTimeout, other.MaximumCacheTimeout)
                 && base.Equals(other);
         }
-
-        // TODO: remove if LookupClient settings can be made readonly
-        internal LookupClientSettings Copy(
-            IReadOnlyCollection<NameServer> nameServers,
-            TimeSpan? minimumCacheTimeout,
-            bool? continueOnDnsError = null,
-            bool? enableAuditTrail = null,
-            bool? recursion = null,
-            int? retries = null,
-            bool? throwDnsErrors = null,
-            TimeSpan? timeout = null,
-            bool? useCache = null,
-            bool? useRandomNameServer = null,
-            bool? useTcpFallback = null,
-            bool? useTcpOnly = null)
-        {
-            // auto resolved flag might get lost here. But this stuff gets deleted anyways.
-            return new LookupClientSettings(new LookupClientOptions(nameServers?.ToArray())
-            {
-                MinimumCacheTimeout = minimumCacheTimeout,
-                ContinueOnDnsError = continueOnDnsError ?? ContinueOnDnsError,
-                EnableAuditTrail = enableAuditTrail ?? EnableAuditTrail,
-                Recursion = recursion ?? Recursion,
-                Retries = retries ?? Retries,
-                ThrowDnsErrors = throwDnsErrors ?? ThrowDnsErrors,
-                Timeout = timeout ?? Timeout,
-                UseCache = useCache ?? UseCache,
-                UseRandomNameServer = useRandomNameServer ?? UseRandomNameServer,
-                UseTcpFallback = useTcpFallback ?? UseTcpFallback,
-                UseTcpOnly = useTcpOnly ?? UseTcpOnly,
-                MaximumCacheTimeout = MaximumCacheTimeout,
-                ExtendedDnsBufferSize = ExtendedDnsBufferSize,
-                RequestDnsSecRecords = RequestDnsSecRecords,
-                ContinueOnEmptyResponse = ContinueOnEmptyResponse
-            });
-        }
-
-        // TODO: remove if LookupClient settings can be made readonly
-        internal LookupClientSettings WithContinueOnDnsError(bool value)
-        {
-            return Copy(NameServers, MinimumCacheTimeout, continueOnDnsError: value);
-        }
-
-        // TODO: remove if LookupClient settings can be made readonly
-        internal LookupClientSettings WithEnableAuditTrail(bool value)
-        {
-            return Copy(NameServers, MinimumCacheTimeout, enableAuditTrail: value);
-        }
-
-        // TODO: remove if LookupClient settings can be made readonly
-        internal LookupClientSettings WithMinimumCacheTimeout(TimeSpan? value)
-        {
-            return Copy(NameServers, minimumCacheTimeout: value);
-        }
-
-        // TODO: remove if LookupClient settings can be made readonly
-        internal LookupClientSettings WithRecursion(bool value)
-        {
-            return Copy(NameServers, MinimumCacheTimeout, recursion: value);
-        }
-
-        // TODO: remove if LookupClient settings can be made readonly
-        internal LookupClientSettings WithRetries(int value)
-        {
-            return Copy(NameServers, MinimumCacheTimeout, retries: value);
-        }
-
-        // TODO: remove if LookupClient settings can be made readonly
-        internal LookupClientSettings WithThrowDnsErrors(bool value)
-        {
-            return Copy(NameServers, MinimumCacheTimeout, throwDnsErrors: value);
-        }
-
-        // TODO: remove if LookupClient settings can be made readonly
-        internal LookupClientSettings WithTimeout(TimeSpan value)
-        {
-            return Copy(NameServers, MinimumCacheTimeout, timeout: value);
-        }
-
-        // TODO: remove if LookupClient settings can be made readonly
-        internal LookupClientSettings WithUseCache(bool value)
-        {
-            return Copy(NameServers, MinimumCacheTimeout, useCache: value);
-        }
-
-        // TODO: remove if LookupClient settings can be made readonly
-        internal LookupClientSettings WithUseTcpFallback(bool value)
-        {
-            return Copy(NameServers, MinimumCacheTimeout, useTcpFallback: value);
-        }
-
-        // TODO: remove if LookupClient settings can be made readonly
-        internal LookupClientSettings WithUseTcpOnly(bool value)
-        {
-            return Copy(NameServers, MinimumCacheTimeout, useTcpOnly: value);
-        }
     }
 
 #pragma warning restore CS0659 // Type overrides Object.Equals(object o) but does not override Object.GetHashCode()

src/DnsClient/ILookupClient.cs

@@ -1,8 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
-using System.Net;
-using System.Threading;
 
 namespace DnsClient
 {