Commit 5da7c34
committed
[lldb-dap] Always pass disableASLR to the DAP executable
More context can be found in
llvm#110303
For DAP tests running in constrained environments (e.g., Docker
containers), disabling ASLR isn't allowed. So we set `disableASLR=False`
(since llvm#113593).
However, the `dap_server.py` will currently only forward the value
of `disableASLR` to the DAP executable if it's set to `True`. If the
DAP executable wasn't provided a `disableASLR` field it defaults to
`true` too
(https://github.com/llvm/llvm-project/blob/f14743794587db102c6d1b20f9c87a1ac20decfd/lldb/tools/lldb-dap/lldb-dap.cpp#L2103-L2104).
This means that passing `disableASLR=False` from the tests is currently
not possible.
This is also true for many of the other boolean arguments of
`request_launch`. But this patch only addresses `disableASLR` for now
since it's blocking a libc++ patch.1 parent 09c258e commit 5da7c34
File tree
1 file changed
+1
-2
lines changed- lldb/packages/Python/lldbsuite/test/tools/lldb-dap
1 file changed
+1
-2
lines changedLines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
793 | 793 | | |
794 | 794 | | |
795 | 795 | | |
796 | | - | |
797 | | - | |
798 | 796 | | |
799 | 797 | | |
800 | 798 | | |
| |||
829 | 827 | | |
830 | 828 | | |
831 | 829 | | |
| 830 | + | |
832 | 831 | | |
833 | 832 | | |
834 | 833 | | |
| |||
0 commit comments