Fix arithmetic overflow in Test-PasswordQuality with empty dictionary file

MichaelGrafnetter · claude · MichaelGrafnetter · commit b0dbfcc29e21 · 2026-03-25T00:07:09.000+01:00
The ReportProgress method would divide by zero when fileLength was 0. Add an early return when fileLength <= 0 to prevent the division. Fixes #219 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
diff --git a/Src/DSInternals.PowerShell/Commands/Misc/TestPasswordQualityCommand.cs b/Src/DSInternals.PowerShell/Commands/Misc/TestPasswordQualityCommand.cs
@@ -442,10 +442,13 @@ private void TestWeakNTHashesFromUnsortedFile()
 
     private void ReportProgress(long fileLength, long position, ProgressRecord progress)
     {
-        if (position >= fileLength)
+        if (fileLength <= 0 || position >= fileLength)
         {
             // Report operation completion
             progress.RecordType = ProgressRecordType.Completed;
+            progress.PercentComplete = 100;
+            this.WriteProgress(progress);
+            return;
         }
 
         // Calculate the current progress

Original file line number	Diff line number	Diff line change
`@@ -442,10 +442,13 @@ private void TestWeakNTHashesFromUnsortedFile()`
`442`	`442`
`443`	`443`	`private void ReportProgress(long fileLength, long position, ProgressRecord progress)`
`444`	`444`	`{`
`445`		`- if (position >= fileLength)`
	`445`	`+ if (fileLength <= 0 \|\| position >= fileLength)`
`446`	`446`	`{`
`447`	`447`	`// Report operation completion`
`448`	`448`	`progress.RecordType = ProgressRecordType.Completed;`
	`449`	`+ progress.PercentComplete = 100;`
	`450`	`+ this.WriteProgress(progress);`
	`451`	`+ return;`
`449`	`452`	`}`
`450`	`453`
`451`	`454`	`// Calculate the current progress`