@Subscription on Apollo v2 and v3

[AaronNGray]

I have some near standard code hear taken from https://github.com/the-road-to-graphql/fullstack-apollo-subscription-example which is version 2 and I modified to work with version 3.

https://github.com/AaronNGray/fullstack-apollo-3.0-subscription-example

I have modified to use type-graphql. What I am doing wrong it might just be in the @subscription code on v2 :-
https://github.com/AaronNGray/fullstack-apollo-2.1.0-subscription-type-graphql-example

I have also modified the version 3 code to use type-graphql :-
https://github.com/AaronNGray/fullstack-apollo-3.0-subscription-type-graphql-example/

I am getting the same results on each with the type-graphql subscription code not working. Its probably down to my code on v2 :-

import { InputType, ObjectType, Field, Resolver, Query, Subscription, Root, Arg } from 'type-graphql';
import 'reflect-metadata';

@ObjectType()
export class Message {
    @Field(type => Number)
    id: Number = 0
    @Field(type => String)
    content: String = ""
};

@InputType()
export class MessageInput {
    @Field(type => Number)
    id: Number = 0
    @Field(type => String)
    content: String = ""
};

@Resolver(Message)
export class MessageResolver {
    @Query(returns => [Message])
    messages(): Message[] {
        return [
            { id: 0, content: 'Hello!' },
            { id: 1, content: 'Bye!' },
        ];
    }

    @Subscription(returns => Message, {
        topics: "MESSAGE_CREATED"
    })
    messageCreated(
        @Arg("message", type => MessageInput) message : Message
    ): Message {
        console.log(message);
        return message;
    }
};

[MichalLytek]

I have also modified the version 3 code to use type-graphql :-

I don't see TypeGraphQL here:
https://github.com/AaronNGray/fullstack-apollo-3.0-subscription-type-graphql-example/blob/main/server/src/index.js

[AaronNGray]

@MichalLytek - Sorry made a mistake, fixed now !

[MichalLytek]

Sorry, I'm out. Your code does not compile. Try to prepare better examples, otherwise no one will help you.

[AaronNGray]

@MichalLytek - Very sorry its the TypeScript version; should I have noticed and said.

Heres, the sources I have been working with all derived from the original project, and Apollo documentation :-

https://github.com/the-road-to-graphql/fullstack-apollo-subscription-example

https://github.com/AaronNGray/fullstack-apollo-2.1.0-subscription-example (subscriptions working)
https://github.com/AaronNGray/fullstack-apollo-3.0-subscription-example (subscriptions working)

https://github.com/AaronNGray/fullstack-apollo-2.1.0-subscription-type-graphql-example
https://github.com/AaronNGray/fullstack-apollo-2.1.0-subscription-type-graphql-example/blob/main/server/src/index.ts
https://github.com/AaronNGray/fullstack-apollo-2.1.0-subscription-type-graphql-example/blob/main/server/src/types.ts

https://github.com/AaronNGray/fullstack-apollo-3.0-subscription-type-graphql-example
https://github.com/AaronNGray/fullstack-apollo-3.0-subscription-type-graphql-example/blob/main/server/src/index.ts
https://github.com/AaronNGray/fullstack-apollo-3.0-subscription-type-graphql-example/blob/main/server/src/types.ts

[MichalLytek]

https://typegraphql.com/docs/subscriptions.html#using-a-custom-pubsub-system

All we need to do is create an instance of PubSub according to the package instructions and then provide it to the TypeGraphQL buildSchema options

[AaronNGray]

@MichalLytek - Thanks I realized how stupid I was at 6am this morning and got it working.

I have update the above repos.

Just need to do a proper example for graphql-ws now :)