Chore: Unit tests

- Added more unit tests;
- Small fixes;

Author: OleksiiBulba

.gitignore

@@ -1,2 +1,3 @@
 vendor
 composer.lock
+.phpunit.result.cache

src/Asset/EntrypointLookup.php

@@ -63,10 +63,12 @@ private function validateEntryName(string $entryName)
     {
         $entriesData = $this->getEntriesData();
         if (!isset($entriesData['entrypoints'][$entryName])) {
-            $withoutExtension = substr($entryName, 0, strrpos($entryName, '.'));
+            if (false !== $dotPos = strrpos($entryName, '.')) {
+                $withoutExtension = substr($entryName, 0, $dotPos);
 
-            if (isset($entriesData['entrypoints'][$withoutExtension])) {
-                throw new EntrypointNotFoundException(sprintf('Could not find the entry "%s". Try "%s" instead (without the extension).', $entryName, $withoutExtension));
+                if (isset($entriesData['entrypoints'][$withoutExtension])) {
+                    throw new EntrypointNotFoundException(sprintf('Could not find the entry "%s". Try "%s" instead (without the extension).', $entryName, $withoutExtension));
+                }
             }
 
             throw new EntrypointNotFoundException(sprintf('Could not find the entry "%s" in "%s". Found: %s.', $entryName, $this->getEntrypointJsonPath(), implode(', ', array_keys($entriesData['entrypoints']))));

tests/Asset/EntrypointLookupTest.php

@@ -0,0 +1,106 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Boo\WebpackEncorePlugin\Tests\Asset;
+
+use Boo\WebpackEncorePlugin\Asset\EntrypointLookup;
+use Boo\WebpackEncorePlugin\WebpackEncorePluginConfigurationInterface;
+use PHPUnit\Framework\TestCase;
+
+class EntrypointLookupTest extends TestCase
+{
+    private EntrypointLookup $model;
+
+    protected function setUp(): void
+    {
+        $configurationMock = $this->getMockBuilder(WebpackEncorePluginConfigurationInterface::class)
+            ->disableOriginalConstructor()
+            ->onlyMethods(['getOutputPath'])
+            ->getMockForAbstractClass();
+
+        $configurationMock->expects($this->any())
+            ->method('getOutputPath')
+            ->willReturn(__DIR__.'/../fixtures/build');
+
+        $this->model = new EntrypointLookup($configurationMock);
+    }
+
+    /**
+     * @dataProvider getCssFilesDataProvider
+     */
+    public function testGetCssFiles(string $entryName, array $expectedResult): void
+    {
+        $this->assertEquals($expectedResult, $this->model->getCssFiles($entryName));
+    }
+
+    public function getCssFilesDataProvider(): array
+    {
+        return [
+            [
+                'entryName' => 'entrypoint1',
+                'expectedResult' => [],
+            ],
+            [
+                'entryName' => 'entrypoint2',
+                'expectedResult' => [
+                    "/some/path/to/js/file.css"
+                ],
+            ],
+        ];
+    }
+
+    /**
+     * @dataProvider getJavaScriptFilesDataProvider
+     */
+    public function testGetJavaScriptFiles(string $entryName, array $expectedResult): void
+    {
+        $this->assertEquals($expectedResult, $this->model->getJavaScriptFiles($entryName));
+    }
+
+    public function getJavaScriptFilesDataProvider(): array
+    {
+        return [
+            [
+                'entryName' => 'entrypoint1',
+                'expectedResult' => [
+                    "/some/path/to/jsFile.js",
+                    "/another/path/to/js/file.js",
+                    "/build/app.js",
+                ],
+            ],
+            [
+                'entryName' => 'entrypoint2',
+                'expectedResult' => [
+                    "/some/path/to/another/js/file.js",
+                ],
+            ],
+        ];
+    }
+
+    /**
+     * @dataProvider entryExistsDataProvider
+     */
+    public function testEntryExists(string $entryName, bool $expectedResult): void
+    {
+        $this->assertEquals($expectedResult, $this->model->entryExists($entryName));
+    }
+
+    public function entryExistsDataProvider(): array
+    {
+        return [
+            [
+                'entryName' => 'entrypoint1',
+                'expectedResult' => true,
+            ],
+            [
+                'entryName' => 'entrypoint2',
+                'expectedResult' => true,
+            ],
+            [
+                'entryName' => 'entrypoint3',
+                'expectedResult' => false,
+            ],
+        ];
+    }
+}

tests/TagRenderer/TagRendererTest.php

@@ -6,13 +6,14 @@
 
 use Boo\WebpackEncorePlugin\Asset\EntrypointLookupInterface;
 use Boo\WebpackEncorePlugin\TagRenderer\TagRenderer;
+use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
 class TagRendererTest extends TestCase
 {
-    private $model;
+    private TagRenderer $model;
 
-    private $entrypointLookupMock;
+    private EntrypointLookupInterface|MockObject $entrypointLookupMock;
 
     protected function setUp(): void
     {
@@ -53,7 +54,7 @@ public function renderWebpackLinkTagsDataProvider(): array
                     '/path/to/css/file.css',
                     '/path/to/another/css/file.css',
                 ],
-                'expectedLinkTagString' => '<link rel="stylesheet" href="/path/to/css/file.css"><link rel="stylesheet" href="/path/to/another/css/file.css">',
+                'expectedLinkTagString' => /** @lang text */ '<link rel="stylesheet" href="/path/to/css/file.css"><link rel="stylesheet" href="/path/to/another/css/file.css">',
             ]
         ];
     }
@@ -87,7 +88,7 @@ public function renderWebpackScriptTagsDataProvider(): array
                     '/path/to/js/file.js',
                     '/path/to/another/js/file.js',
                 ],
-                'expectedScriptTagString' => '<script src="/path/to/js/file.js" type="application/javascript"></script><script src="/path/to/another/js/file.js" type="application/javascript"></script>',
+                'expectedScriptTagString' => /** @lang text */ '<script src="/path/to/js/file.js" type="application/javascript"></script><script src="/path/to/another/js/file.js" type="application/javascript"></script>',
             ]
         ];
     }

tests/fixtures/build/entrypoints.json

@@ -0,0 +1,19 @@
+{
+    "entrypoints": {
+        "entrypoint1": {
+            "js": [
+                "/some/path/to/jsFile.js",
+                "/another/path/to/js/file.js",
+                "/build/app.js"
+            ]
+        },
+        "entrypoint2": {
+            "js": [
+                "/some/path/to/another/js/file.js"
+            ],
+            "css": [
+                "/some/path/to/js/file.css"
+            ]
+        }
+    }
+}