code review

Parithi098 · Parithi098 · commit 74c7f50d2550 · 2025-06-23T16:31:01.000+05:30
diff --git a/cli/mfg.c b/cli/mfg.c
@@ -2335,7 +2335,7 @@ static int sjtag_unlock(int argc, char **argv)
         ret = switchtec_sjtag_status_get(cfg.dev, &status);
         if (ret)
 		{
-			switchtec_perror("Failed to the retrive the SJTAG Status from the device");
+			switchtec_perror("Failed to retrive the SJTAG Status from the device");
 			ret = -1;
 			break;
 		}
@@ -2345,7 +2345,7 @@ static int sjtag_unlock(int argc, char **argv)
             printf("SJTAG Mode: %x\n", (status.data & 0x03));
         }
 
-        /* For Open mode - Unlock status(status.data[3]) should 1 */
+        /* For Open mode - Unlock status(status.data[2]) should 1 */
         if ((((status.data & 0x03) == 0x00) || ((status.data & 0x04) == 0x04)) && (false == cfg.force_hr))
         {
             printf("SJTAG is in Open State\n");

Original file line number	Diff line number	Diff line change
`@@ -2335,7 +2335,7 @@ static int sjtag_unlock(int argc, char **argv)`
`2335`	`2335`	`ret = switchtec_sjtag_status_get(cfg.dev, &status);`
`2336`	`2336`	`if (ret)`
`2337`	`2337`	`{`
`2338`		`- switchtec_perror("Failed to the retrive the SJTAG Status from the device");`
	`2338`	`+ switchtec_perror("Failed to retrive the SJTAG Status from the device");`
`2339`	`2339`	`ret = -1;`
`2340`	`2340`	`break;`
`2341`	`2341`	`}`
`@@ -2345,7 +2345,7 @@ static int sjtag_unlock(int argc, char **argv)`
`2345`	`2345`	`printf("SJTAG Mode: %x\n", (status.data & 0x03));`
`2346`	`2346`	`}`
`2347`	`2347`
`2348`		`- /* For Open mode - Unlock status(status.data[3]) should 1 */`
	`2348`	`+ /* For Open mode - Unlock status(status.data[2]) should 1 */`
`2349`	`2349`	`if ((((status.data & 0x03) == 0x00) \|\| ((status.data & 0x04) == 0x04)) && (false == cfg.force_hr))`
`2350`	`2350`	`{`
`2351`	`2351`	`printf("SJTAG is in Open State\n");`