graph working for eye

Author: vigneshraja123717

cli/diag.c

@@ -933,7 +933,7 @@ static int crosshair(int argc, char **argv)
 		.y_range.step = 5,
 	};
 	const struct argconfig_options opts[] = {
-		DEVICE_OPTION_OPTIONAL,
+		DEVICE_OPTION,
 		{"all", 'a', "", CFG_NONE, &cfg.all, no_argument,
 		 "capture all lanes, format must be csv"},
 		{"crosshair", 'C', "FILE", CFG_FILE_R, &cfg.crosshair_file,
@@ -1094,7 +1094,6 @@ int eye_observe_dev(struct switchtec_dev *dev, unsigned int error_threshold,
 		switchtec_perror("eye_start");
 	}
 
-	printf("started\n");
 	ret = switchtec_diag_eye_fetch(dev, &data_out);
 
 	memcpy(&eye_data[0], &data_out, sizeof(struct switchtec_diag_port_eye_data));
@@ -1127,7 +1126,7 @@ static int eye(int argc, char **argv)
           .v_step = 1,
   };
   const struct argconfig_options opts[] = {
-          DEVICE_OPTION_OPTIONAL,
+          DEVICE_OPTION,
           {"format", 'f', "FMT", CFG_CHOICES, &cfg.fmt, required_argument,
            "output format (default: " FMT_DEFAULT_STR ")",
            .choices=output_fmt_choices},
@@ -1143,8 +1142,8 @@ static int eye(int argc, char **argv)
 
 	argconfig_parse(argc, argv, CMD_DESC_EYE, opts, &cfg,
                        sizeof(cfg));
-	
-	ret = eye_observe_dev(cfg.dev, cfg.lane_id, cfg.error_threshold, &gen);
+
+	ret = eye_observe_dev(cfg.dev, cfg.error_threshold, cfg.lane_id, &gen);
 
 	return ret;
 }

cli/graph.c

@@ -381,7 +381,6 @@ void get_screen_coords(int x, int y, int *sx, int *sy) {
 
 void plot_point(int x, int y) 
 {
-    printf("X %d Y %d\n", x, y);
     mvprintw(y/Y_SCALE, x*X_SCALE, "O (%d,%d)", x-Y_PRINT_OFFSET, y-X_PRINT_OFFSET);
 }
 

inc/switchtec/diag.h

@@ -279,5 +279,30 @@ struct switchtec_diag_cross_hair_get {
 	};
 };
 
+typedef enum {
+    /* command error code for Start, fetch and cancel */
+    EOM_SUCCESS,                  /* EOM general result, means no error */
+
+    /* Error codes for EOM Start sub command */
+    EOM_FAILED_TO_START,          /* EOM Failed to Start*/
+    EOM_INVALID_PARAMETER,        /* EOM parameter error */
+    EOM_PREV_CMD_NOT_FINISHED,    /* EOM cmd error, the previous cmd has not finished */
+
+    /* Error codes for EOM Fetch Sub command */
+    EOM_IN_PROGRESS,              /* EOM in progress, but no output data yet */
+    EOM_NOT_RUNNING,              /*EOM Not running*/
+
+    /* Error codes for EOM Cancel sub command*/
+    EOM_FAILED_TO_CANCEL,         /*EOM Failed to cancel*/
+
+    /* error codes for EOM Running state machine*/
+    EOM_SPEED_IS_NOT_GEN3_OR_4,   /* EOM Speed is not Gen3 or 4*/
+    EOM_MARGIN_CODE_OUT_OF_RANGE, /* EOM Margin code out of range*/
+    EOM_WAITING_FOR_HARDWARE,     /* EOM waiting for hardware*/
+
+    /*Invalid error code*/
+    EOM_ERROR = 0xFF,
+} mrpc_stat_eom_enum;
+
 #endif
 /**@}*/

lib/diag.c

@@ -231,17 +231,16 @@ int switchtec_diag_eye_fetch(struct switchtec_dev *dev, struct switchtec_diag_po
 	if (ret)
 		return ret;
 
-	printf("status %d\n", out.status);
-	if(out.status > 9)
+	if(out.status > EOM_WAITING_FOR_HARDWARE)
 	{
 		return ret;
 	}
 
-	if (out.status == 4) {
+	if (out.status == EOM_IN_PROGRESS) {
 		usleep(5000);
 		goto retry;
 	}
-	else if(out.status == 0)
+	else if(out.status == EOM_SUCCESS)
 	{
 		printf("Eye Left %d\n", out.eye_left);
        	 	printf("Eye Right %d\n", out.eye_right);