Skip to content

Commit a032a48

Browse files
ChaitanayaKulkarnikeithbusch
authored andcommitted
nvme: fix compiler warnings
This patch fixes the following errors :- nvme-topology.c: In function ‘verify_legacy_ns’: nvme-topology.c:361:32: error: format not a string literal and no format arguments [-Werror=format-security] 361 | asprintf(&n->ctrl->address, tmp_address); | ^~~~~~~~~~~ nvme-topology.c:360:4: error: ignoring return value of ‘asprintf’, declared with attribute warn_unused_result [-Werror=unused-result] 360 | asprintf(&n->ctrl->transport, "pcie"); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ nvme-topology.c:361:4: error: ignoring return value of ‘asprintf’, declared with attribute warn_unused_result [-Werror=unused-result] 361 | asprintf(&n->ctrl->address, tmp_address); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make: *** [Makefile:96: nvme-topology.o] Error 1 This can be easily re produced on the gcc version :- (Ubuntu 9.2.1-9ubuntu2) 9.2.1 20191008 Signed-off-by: Chaitanya Kulkarni <[email protected]>
1 parent f51db58 commit a032a48

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

nvme-topology.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -357,8 +357,10 @@ static int verify_legacy_ns(struct nvme_namespace *n)
357357
char tmp_address[64] = "";
358358
legacy_get_pci_bdf(path, tmp_address);
359359
if (tmp_address[0]) {
360-
asprintf(&n->ctrl->transport, "pcie");
361-
asprintf(&n->ctrl->address, tmp_address);
360+
if (asprintf(&n->ctrl->transport, "pcie") != 1)
361+
return -1;
362+
if (asprintf(&n->ctrl->address, "%s", tmp_address) != 1)
363+
return -1;
362364
}
363365
}
364366

0 commit comments

Comments
 (0)